From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F4BC04AAA for ; Thu, 2 May 2019 14:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C4C72081C for ; Thu, 2 May 2019 14:19:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726442AbfEBOTr (ORCPT ); Thu, 2 May 2019 10:19:47 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:39513 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbfEBOTr (ORCPT ); Thu, 2 May 2019 10:19:47 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 44vy803DdJz9sBr; Fri, 3 May 2019 00:19:44 +1000 (AEST) From: Michael Ellerman To: linux-edac@vger.kernel.org Cc: morbidrsa@gmail.com, bp@alien8.de, mchehab@kernel.org, james.morse@arm.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: [PATCH] EDAC, mpc85xx: Prevent building as a module Date: Fri, 3 May 2019 00:19:41 +1000 Message-Id: <20190502141941.12927-1-mpe@ellerman.id.au> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The mpc85xx EDAC code can be configured as a module but then fails to build because it uses two unexported symbols: ERROR: ".pci_find_hose_for_OF_device" [drivers/edac/mpc85xx_edac_mod.ko] undefined! ERROR: ".early_find_capability" [drivers/edac/mpc85xx_edac_mod.ko] undefined! We don't want to export those symbols just for this driver, so make the driver only configurable as a built-in. This seems to have been broken since at least commit c92132f59806 ("edac/85xx: Add PCIe error interrupt edac support") (Nov 2013). Signed-off-by: Michael Ellerman --- drivers/edac/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 47eb4d13ed5f..6317519f9d88 100644 --- a/drivers/edac/Kconfig +++ b/drivers/edac/Kconfig @@ -263,7 +263,7 @@ config EDAC_PND2 micro-server but may appear on others in the future. config EDAC_MPC85XX - tristate "Freescale MPC83xx / MPC85xx" + bool "Freescale MPC83xx / MPC85xx" depends on FSL_SOC help Support for error detection and correction on the Freescale -- 2.20.1