From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BFDC43219 for ; Fri, 3 May 2019 06:26:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D52E21479 for ; Fri, 3 May 2019 06:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556864804; bh=PbnOtQTPk1YWI1baljC7st8kUTPaoL4I1dl5ooBKBns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=b1Y4mynmNwTFjL2YY8OYwn+hf2+ycG5YcIzn+FXFwkGSvU2Te3SUPmcPFIwQAA5Jr vPyQUeLk+hcdhhvY6aA630yKw5rJd0ZrvPNWZnGiKdZWYJ/2vd0QziaoPFyvVXrqLD cUa6CencIXQSwtUuG3qdH9xrZ4wvs6xbm9IzqYZo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726776AbfECG0n (ORCPT ); Fri, 3 May 2019 02:26:43 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:38698 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfECG0n (ORCPT ); Fri, 3 May 2019 02:26:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4zAV5FNZ7iSvw6XP0dpEY1QjT1Lu6JpO/I5zpIga3/M=; b=TxH1Zfhw/7v5Er9Lx6Kc5hn7A mU9sO3BvY4h+O+NsPqPba3lODFPXEQMHkuH1/dssDMcGYntLx2o7cefmO3s/XPsibcKQgfmNEssTO UH39HM1pCLtytOrnEb8RMlB99qafmtIOCYzb+B6AJraqCNt4ll8eitDFK5wcUDjyY/TV8=; Received: from [42.29.24.106] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hMReR-0000qf-KN; Fri, 03 May 2019 06:26:32 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id D019C441D3C; Fri, 3 May 2019 07:26:26 +0100 (BST) Date: Fri, 3 May 2019 15:26:26 +0900 From: Mark Brown To: Jorge Ramirez Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, bjorn.andersson@linaro.org, vinod.koul@linaro.org, niklas.cassel@linaro.org, khasim.mohammed@linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/3] drivers: regulator: qcom: add PMS405 SPMI regulator Message-ID: <20190503062626.GE14916@sirena.org.uk> References: <20190502023316.GS14916@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3rxX7Uty8SZY8iU1" Content-Disposition: inline In-Reply-To: X-Cookie: -- I have seen the FUN -- User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3rxX7Uty8SZY8iU1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 02, 2019 at 01:30:48PM +0200, Jorge Ramirez wrote: > On 5/2/19 04:33, Mark Brown wrote: > > I'm not sure I follow here, sorry - I can see that the driver needs a > > custom get/set selector operation but shouldn't it be able to use the > > standard list and map operations for linear ranges? > I agree it should, but unfortunately that is not the case; when I first > posted the patch I was concerned that for a regulator to be supported by > this driver it should obey to the driver's internals (ie: comply with > all of the spmi_common_regulator_registers definitions). That's not a requirement that I'd particularly expect - it's not unusual for devices to have multiple different styles of regulators in a single chip (eg, DCDCs often have quite different register maps to LDOs). > However, since there was just a single range to support, the > modifications I had to do to support this SPMI regulator were minimal - > hence why I opted for the changes under discussion instead of writing a > new driver (which IMO it is an overkill). > what do you think? It seems a bit of a jump to add a new driver - it's just another descriptor and ops structure isn't it? Though as ever with the Qualcomm stuff this driver is pretty baroque which doesn't entirely help though I think it's just another regulator type which there's already some handling for. --3rxX7Uty8SZY8iU1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlzL3xIACgkQJNaLcl1U h9CKXQf/Qvobc1RebHM+jpqmN1w+403J3a8AYm+cJYEEi5WdT9/tMTuFx1gdj6XZ K9nnzqV9352C2R/rWD3otwlV3u+HHMTQVZA5nx021V52khQJs9mNQQKxBcAO1bUp kou03On7TG8RlPQrCmiHr1YLb63L3WiN/m4ekWUzFwYMbe8IlqV9gNzajRg34IO2 mh9MwIIevGkndKkrk5JTA7oJw7DGWS8lAIc/nS6m85L7K3z9QdRQKyL6gR5kTYMG uczLsAwmPcdyV5faFjd9Q+hFycqeE+SU5iU9yND7diDPq6p2C4NKyKDl2IFElVgA xfiLvU4z9kaJrlzB/K+/GBc2IB0wsQ== =jNk7 -----END PGP SIGNATURE----- --3rxX7Uty8SZY8iU1--