From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Christian Gromm <christian.gromm@microchip.com>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
Andrey Shvetsov <andrey.shvetsov@k2l.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
Colin Ian King <colin.king@canonical.com>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
Takashi Iwai <tiwai@suse.de>,
Marcin Ciupak <marcin.s.ciupak@gmail.com>,
Suresh Udipi <sudipi@jp.adit-jv.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>
Subject: Re: [PATCH] staging: most: cdev: fix chrdev_region leak in mod_exit
Date: Fri, 3 May 2019 09:40:41 +0200 [thread overview]
Message-ID: <20190503074041.GA4686@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <20190502173920.GA14304@kroah.com>
On Thu, May 02, 2019 at 07:39:20PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 24, 2019 at 09:23:43PM +0200, Eugeniu Rosca wrote:
> > From: Suresh Udipi <sudipi@jp.adit-jv.com>
> >
> > It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0
> > commit [1] missed to fix the memory leak in mod_exit function.
> >
> > Do it now.
> >
> > [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak")
> > [1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381
> > ("staging: most: cdev: fix leak for chrdev_region")
> >
> > Signed-off-by: Suresh Udipi <sudipi@jp.adit-jv.com>
> > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> > Acked-by: Christian Gromm <christian.gromm@microchip.com>
>
> In the future, please use the "correct" way to mark a fixup patch. For
> this, it would be:
> Fixes: aba258b73101 ("staging: most: cdev: fix chrdev_region leak")
>
> I'll go add it, and the needed stable tag to the patch when applying it.
Thank you for the suggestion. I'll follow it next time.
>
> thanks,
>
> greg k-h
--
Best Regards,
Eugeniu.
prev parent reply other threads:[~2019-05-03 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 19:23 Eugeniu Rosca
2019-05-01 16:17 ` Greg Kroah-Hartman
2019-05-02 8:02 ` Christian.Gromm
2019-05-02 17:39 ` Greg Kroah-Hartman
2019-05-03 7:40 ` Eugeniu Rosca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503074041.GA4686@vmlxhi-102.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=andrey.shvetsov@k2l.de \
--cc=christian.gromm@microchip.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.s.ciupak@gmail.com \
--cc=o-takashi@sakamocchi.jp \
--cc=roscaeugeniu@gmail.com \
--cc=sudipi@jp.adit-jv.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®