From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E5F3C43219 for ; Fri, 3 May 2019 15:34:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E8C62087F for ; Fri, 3 May 2019 15:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728341AbfECPeq (ORCPT ); Fri, 3 May 2019 11:34:46 -0400 Received: from 8bytes.org ([81.169.241.247]:39306 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726724AbfECPep (ORCPT ); Fri, 3 May 2019 11:34:45 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id A604B580; Fri, 3 May 2019 17:34:44 +0200 (CEST) Date: Fri, 3 May 2019 17:34:43 +0200 From: Joerg Roedel To: Eric Auger Cc: eric.auger.pro@gmail.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, dwmw2@infradead.org Subject: Re: [PATCH] iommu/vt-d: Fix leak in intel_pasid_alloc_table on error path Message-ID: <20190503153443.GD11605@8bytes.org> References: <20190430073004.10528-1-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430073004.10528-1-eric.auger@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 09:30:04AM +0200, Eric Auger wrote: > If alloc_pages_node() fails, pasid_table is leaked. Free it. > > Fixes: cc580e41260db ("iommu/vt-d: Per PCI device pasid table interfaces") > > Signed-off-by: Eric Auger > --- > drivers/iommu/intel-pasid.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied, thanks.