From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1899C43219 for ; Fri, 3 May 2019 19:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C95F20651 for ; Fri, 3 May 2019 19:07:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726984AbfECTHf (ORCPT ); Fri, 3 May 2019 15:07:35 -0400 Received: from smtp-out.xnet.cz ([178.217.244.18]:14192 "EHLO smtp-out.xnet.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726769AbfECTHe (ORCPT ); Fri, 3 May 2019 15:07:34 -0400 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id 0A3B13233; Fri, 3 May 2019 21:07:32 +0200 (CEST) Received: from localhost (meh.true.cz [local]) by meh.true.cz (OpenSMTPD) with ESMTPA id 064ad94e; Fri, 3 May 2019 21:07:30 +0200 (CEST) Date: Fri, 3 May 2019 21:07:30 +0200 From: Petr =?utf-8?Q?=C5=A0tetiar?= To: Dan Carpenter Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andrew Lunn , Florian Fainelli , Maxime Ripard , linux-kernel@vger.kernel.org, Srinivas Kandagatla , Frank Rowand , Heiner Kallweit Subject: Re: [PATCH v3 08/10] staging: octeon-ethernet: support of_get_mac_address new ERR_PTR error Message-ID: <20190503190730.GH71477@meh.true.cz> Reply-To: Petr =?utf-8?Q?=C5=A0tetiar?= References: <1556870168-26864-1-git-send-email-ynezz@true.cz> <1556870168-26864-9-git-send-email-ynezz@true.cz> <20190503103456.GF2269@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190503103456.GF2269@kadam> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Carpenter [2019-05-03 13:34:56]: Hi, > On Fri, May 03, 2019 at 09:56:05AM +0200, Petr Štetiar wrote: > > There was NVMEM support added to of_get_mac_address, so it could now > > return NULL and ERR_PTR encoded error values, so we need to adjust all > > current users of of_get_mac_address to this new fact. > > Which commit added NVMEM support? It hasn't hit net-next or linux-next > yet... Very strange. this patch is a part of the patch series[1], where the 1st patch[2] adds this NVMEM support to of_get_mac_address and follow-up patches are adjusting current of_get_mac_address users to the new ERR_PTR return value. > Why would of_get_mac_address() return a mix of NULL and error pointers? I've introduced this misleading API in v3, but corrected it in v4, so it now returns only valid pointer or ERR_PTR encoded error value. Just FYI, changes for staging/octeon are currently at v5[3]. 1. https://patchwork.ozlabs.org/project/netdev/list/?series=105972 2. https://patchwork.ozlabs.org/patch/1094916/ 3. https://patchwork.ozlabs.org/patch/1094942/ -- ynezz