From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 131CBC04A6B for ; Mon, 6 May 2019 17:54:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9C182053B for ; Mon, 6 May 2019 17:54:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="puewRPLH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbfEFRyQ (ORCPT ); Mon, 6 May 2019 13:54:16 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:41647 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726437AbfEFRyQ (ORCPT ); Mon, 6 May 2019 13:54:16 -0400 Received: by mail-qt1-f196.google.com with SMTP id c13so15778201qtn.8 for ; Mon, 06 May 2019 10:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=QhugHBuoBeAcIwpcanoLwTWHJfxQHnSCegSWAvWi8kU=; b=puewRPLH4Nh/tosb7+eyKJyRGegVRvwvSe51SQhwLutt2q6m0+ltEOplW8mkMCUoiz c9A02CPaqRZaZExZZ8hjy1+Wi12kEipDiFDwJcKNFhoYqxwGNA1xnN+PTUvHSBW+mTrl v1C3cZHCAz+/YObFqsrKCorzir4viKXiogisTmNG/II+6qOgGMez0Dw7PhiX/pfAw5B1 G7jbTG1mSlgyh4DlZaMPtF8WXUwxSHowOeYCVHwF/XVuecLJTzzwrfjLPxAp6kildygK GIZFmG5d6/N8z6/CATq1ii4dfcJvhKRsjRhdbbyGk8DFEDIsTchK0gjtvUxpC+iDOC1q vnEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=QhugHBuoBeAcIwpcanoLwTWHJfxQHnSCegSWAvWi8kU=; b=UxqYNd6vZojixHq8y3J07t3bKE6SUqqoAqwe/+jn/5OPiDMhCgKL1HzjBxH5zCf5Gx lEJuo6iD4Bl93adcH/1dx45CcAfEycYP84+K19svVwIanYFJ8pIKGMPIXkeC2orky39S 7vCo9bukEQC6wHUmMtzbgpHQU3Lm/mhv51Zj8FFAPkoMFKVTj0fABPs82zZWxNohufX9 PEmemjFjO957KuXBUx4biINIJsE4m53Asi62TCMLQ11ZpQvNvJUljPgXG1hJUWUIxPzo 6M5bautQKZlJSpRIZzOY38rpshA3kTxNvXHnl/Qeq+yHvusyF6PAj2TE8uEpS6VsudSI RwrQ== X-Gm-Message-State: APjAAAWVumciISJ2+OSGBKIa2ljAIU1eQO96L1/5+rItWlpKwIbNUdy0 ZGXYK+VG+MSCgNpnD2SBjDXwOw== X-Google-Smtp-Source: APXvYqy5PtVe8FLAX6kDTgdUP43dSzUlx/5JyN5cnA6nyK/VlRdXqugen7LkGUTYbhAIs7gMXx0zyg== X-Received: by 2002:ac8:3157:: with SMTP id h23mr84589qtb.248.1557165255314; Mon, 06 May 2019 10:54:15 -0700 (PDT) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id f6sm6382006qti.4.2019.05.06.10.54.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 06 May 2019 10:54:15 -0700 (PDT) Date: Mon, 6 May 2019 10:54:07 -0700 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com, Russell King , linux-arm-kernel@lists.infradead.org, Saeed Mahameed Subject: Re: [PATCH net-next 0/4] net: mvpp2: cls: Add classification Message-ID: <20190506105407.69ff9a08@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190506100026.7d0094fc@bootlin.com> References: <20190430131429.19361-1-maxime.chevallier@bootlin.com> <20190504025353.74acbb6d@cakuba.netronome.com> <20190506100026.7d0094fc@bootlin.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 May 2019 10:00:26 +0200, Maxime Chevallier wrote: > Hello Jakub, > > On Sat, 4 May 2019 02:53:53 -0400 > Jakub Kicinski wrote: > > >On Tue, 30 Apr 2019 15:14:25 +0200, Maxime Chevallier wrote: > >> Compared to the first submissions, the NETIF_F_NTUPLE flag was also > >> removed, following Saeed's comment. > > > >You should probably add it back, even though the stack only uses > >NETIF_F_NTUPLE for aRFS the ethtool APIs historically depend on the > >drivers doing a lot of the validation. > > OK my bad, reading your previous comments again, I should indeed have > left it. > > I'll re-add the flag, do you think this should go through -net or wait > until net-next reopens ? I think the patch should be relatively simple and clean? So I'd try for net, with a Fixes tag, it's a slight ABI correction and we are still in the merge window period. So I'd go for net :)