From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1EE1C004C9 for ; Tue, 7 May 2019 08:28:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78DC120989 for ; Tue, 7 May 2019 08:28:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="KNYFLCSO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbfEGI2G (ORCPT ); Tue, 7 May 2019 04:28:06 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:33534 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbfEGI2G (ORCPT ); Tue, 7 May 2019 04:28:06 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x478JPdb108465; Tue, 7 May 2019 08:27:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=2q+SX5ysM+eJgpkwPBbiklVLVKN4lqt4X/eshikVH0g=; b=KNYFLCSOSKep/Gp8HP7PVdp1dahEu6lCYIaFenvm93nYuYM6nw7pPJDHtSXNKaRFq+VE yL5fXVDa1/lJhZ51dAhVGL7CuThevoEHR1TQSCjakRgO+/jOiAJTKR+gW3WKJhu6vKje 5mP0WmAnnMKkmhE++fpWIefsN3M/iaPiuQWSk4hyNk+DROJvAWw5XPxFaUWh3v6DNLQL NFobibX0/U6lhAEPRXYp/eebBuSaMmvWsSkzmEQMemNgWCZ+0Tp04rGl4SQXsHZ5+R+C kG0kO62v72iYLq7nBCfG2qzx7qZ/2BsJhzWnAwFqDcjU/SoX8PitvBy8M9eWQAg0/IOW 2w== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2s94b0kdxy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 May 2019 08:27:57 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x478Qxt0075221; Tue, 7 May 2019 08:27:56 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2s94b9bk6u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 May 2019 08:27:56 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x478RpNt018312; Tue, 7 May 2019 08:27:52 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 07 May 2019 01:27:51 -0700 Date: Tue, 7 May 2019 11:27:44 +0300 From: Dan Carpenter To: Colin King Cc: Dmitry Torokhov , Rob Herring , Marco Felsch , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] Input: qt1050: fix less than zero comparison on an unsigned int Message-ID: <20190507082744.GK2269@kadam> References: <20190507082135.21538-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190507082135.21538-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9249 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905070055 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9249 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905070055 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 07, 2019 at 09:21:35AM +0100, Colin King wrote: > From: Colin Ian King > > Currently the less than zero comparison of val is always false because > val is an unsigned int. Fix this by making val a signed int. > > Addresses-Coverity: ("Unsigned compared against zero") > Fixes: a33ff45923c8 ("Input: qt1050 - add Microchip AT42QT1050 support") > Signed-off-by: Colin Ian King > --- > drivers/input/keyboard/qt1050.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c > index 6b1603cb7515..4debddb13972 100644 > --- a/drivers/input/keyboard/qt1050.c > +++ b/drivers/input/keyboard/qt1050.c > @@ -222,7 +222,7 @@ static struct regmap_config qt1050_regmap_config = { > > static bool qt1050_identify(struct qt1050_priv *ts) > { > - unsigned int val; > + int val; This code is checking the wrong thing anyway. It should be: int ret; ret = regmap_read(&val); if (ret) return false; regards, dan carpenter