From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E486EC004C9 for ; Tue, 7 May 2019 14:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3301205C9 for ; Tue, 7 May 2019 14:02:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbfEGOCi (ORCPT ); Tue, 7 May 2019 10:02:38 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:55440 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726063AbfEGOCi (ORCPT ); Tue, 7 May 2019 10:02:38 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB59080D; Tue, 7 May 2019 07:02:37 -0700 (PDT) Received: from queper01-lin (queper01-lin.cambridge.arm.com [10.1.195.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 38CB63F5C1; Tue, 7 May 2019 07:02:35 -0700 (PDT) Date: Tue, 7 May 2019 15:02:33 +0100 From: Quentin Perret To: Vincent Guittot Cc: Luca Abeni , linux-kernel , Greg Kroah-Hartman , "Rafael J . Wysocki" , Ingo Molnar , Peter Zijlstra , "Paul E . McKenney" , Joel Fernandes , Luc Van Oostenryck , Morten Rasmussen , Juri Lelli , Daniel Bristot de Oliveira , Patrick Bellasi , Tommaso Cucinotta Subject: Re: [RFC PATCH 1/6] sched/dl: Improve deadline admission control for asymmetric CPU capacities Message-ID: <20190507140231.5hglz2d64stadbhm@queper01-lin> References: <20190506044836.2914-1-luca.abeni@santannapisa.it> <20190506044836.2914-2-luca.abeni@santannapisa.it> <20190507134850.yreebscc3zigfmtd@queper01-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 07 May 2019 at 15:55:37 (+0200), Vincent Guittot wrote: > On Tue, 7 May 2019 at 15:48, Quentin Perret wrote: > > > > Hi Luca, > > > > On Monday 06 May 2019 at 06:48:31 (+0200), Luca Abeni wrote: > > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > > > index edfcf8d982e4..646d6d349d53 100644 > > > --- a/drivers/base/arch_topology.c > > > +++ b/drivers/base/arch_topology.c > > > @@ -36,6 +36,7 @@ DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE; > > > > > > void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity) > > > { > > > + topology_update_cpu_capacity(cpu, per_cpu(cpu_scale, cpu), capacity); > > > > Why is that one needed ? Don't you end up re-building the sched domains > > after this anyways ? > > I was looking at the same point. > Also this doesn't take into account if the cpu is offline > > Do we also need of the line below in set_rq_online > + rq->rd->rd_capacity += arch_scale_cpu_capacity(NULL, > cpu_of(rq)); > > building the sched_domain seems a better place to set rq->rd->rd_capacity Perhaps this could hook directly in rq_attach_root() ? We don't really need the decrement part no ? That is, in case of hotplug the old rd should be destroyed anyways. Thanks, Quentin > > > > > > per_cpu(cpu_scale, cpu) = capacity; > > > } > > > > Thanks, > > Quentin