From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B103CC04A6B for ; Wed, 8 May 2019 08:41:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89266214C6 for ; Wed, 8 May 2019 08:41:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726931AbfEHIl6 (ORCPT ); Wed, 8 May 2019 04:41:58 -0400 Received: from smtp-out.xnet.cz ([178.217.244.18]:59492 "EHLO smtp-out.xnet.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726387AbfEHIl6 (ORCPT ); Wed, 8 May 2019 04:41:58 -0400 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id DD9AC47A7; Wed, 8 May 2019 10:41:53 +0200 (CEST) Received: from localhost (meh.true.cz [local]) by meh.true.cz (OpenSMTPD) with ESMTPA id a0fd15e7; Wed, 8 May 2019 10:41:52 +0200 (CEST) Date: Wed, 8 May 2019 10:41:52 +0200 From: Petr =?utf-8?Q?=C5=A0tetiar?= To: Rob Herring Cc: netdev , devicetree@vger.kernel.org, "David S. Miller" , Mark Rutland , Andrew Lunn , Vivien Didelot , Florian Fainelli , Yisen Zhuang , Salil Mehta , Woojung Huh , Microchip Linux Driver Support , Kunihiko Hayashi , Masahiro Yamada , Jassi Brar , Kalle Valo , Matthias Brugger , Heiner Kallweit , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-wireless , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH v4 02/10] dt-bindings: doc: reflect new NVMEM of_get_mac_address behaviour Message-ID: <20190508084152.GM81826@meh.true.cz> Reply-To: Petr =?utf-8?Q?=C5=A0tetiar?= References: <1556893635-18549-1-git-send-email-ynezz@true.cz> <1556893635-18549-3-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob Herring [2019-05-07 11:44:57]: Hi, > > -- local-mac-address: the driver is designed to use the of_get_mac_address api > > - only if efuse-mac is 0. When efuse-mac is 0, the MAC > > - address is obtained from local-mac-address. If this > > - attribute is not present, then the driver will use a > > - random MAC address. > > - "netcp-device label": phandle to the device specification for each of NetCP > > sub-module attached to this interface. > > > > +The MAC address will be determined using the optional properties defined in > > +ethernet.txt, as provided by the of_get_mac_address API and only if efuse-mac > > Don't make references to Linux in bindings. You can talk about > expectations of client programs (e.g Linux, u-boot, BSD, etc.) though. I've just tried to reword what was already there, anyway, did I understood your remark properly, would this be more appropriate? The MAC address will be determined using the optional properties defined in ethernet.txt and only if efuse-mac is set to 0. If any of the optional MAC address properties are not present, then the driver will use random MAC address. Thanks! -- ynezz