From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE0F2C04A6B for ; Wed, 8 May 2019 16:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE04C208C3 for ; Wed, 8 May 2019 16:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557332785; bh=iZz/Z/tv2OTEKGJRysB5YIYJc5JOxbXdzuSDE8shWqQ=; h=From:To:Cc:Subject:Date:List-ID:From; b=k5RPvBdK2GehpwtTV58Q2bVO55Wa0YWJM86GIUgTrAGNGM+dif/WWA+wcosFXC4Mp rXqSmbtHNnkE7DMq/1MGawLBhx7JqNXHYE/4NZnSCZ6F7G6hDmL0ABnnL2fMVV5J9z 65P9BWGJt7h3XX7rx8rcQ2e0RKE1gmN/wjOwsyyI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727974AbfEHQ0U (ORCPT ); Wed, 8 May 2019 12:26:20 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:33185 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727515AbfEHQ0T (ORCPT ); Wed, 8 May 2019 12:26:19 -0400 Received: by mail-it1-f196.google.com with SMTP id u16so2721116itc.0 for ; Wed, 08 May 2019 09:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=75vFqUksf0tQ2CrucJLVayay02aXl+jl+xEBhfOLKh8=; b=Byu4evv3/Taq0hD9gQdOBBv7eqPsD0iQj96N0oZ4q6bzkunFBjqxs7K7E+FKM8iZPH 3tgGSJk2srZ8UR5ZnbgDk88nKruFXnxSjKfwQcBQ8RM+8HtDiL9cg8NaPNZo4djwyESi rSigA0zYLJs7uLbX+SAyeqhldjxG5qmZM7rc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=75vFqUksf0tQ2CrucJLVayay02aXl+jl+xEBhfOLKh8=; b=Onqtnit76COOGC5jH3cAyXHT3FLizo5WsSay8ahSfX4WOLbQWNnUXzUocOMk0z8+UQ 5Hj8QVg8ZtUK9CU3/fijc4+VKsFqt3WO8AByTTGisPREnF+ephcyN4ravmDEKqPzPoTx qJtsox1s2tmG4QcmoxBXS7YOcrJExtExtQaeGsVK3/qMBtmgF8oV0QyFT9BiQixS/gKv D+VCj1pp6zUr+ou7fs994/zOKkGQjRmlXvFXql0jp/du5ypuyXvUm8QDKoWGX8BeAC62 GJlk6QCZzJsPM6AT6mexcfrdMUQ3f3IjpCUk8DuAPYCXIhLnDypZQ71VV6O6rzEgMwqB 96jg== X-Gm-Message-State: APjAAAXOTFbTMOhW1x+gCZMtAKN8GdnTibP+CnO4pDwIysmpd6Wdb/Am iI5PGbYdS/SvUEt/gJHaM7oeSQ== X-Google-Smtp-Source: APXvYqzQoskEtmbjbTtX+OwFuML4TDWByi9RvdqJOynVcQV+gClTL5kianyjqI8MKT/DQSvYCHE8RQ== X-Received: by 2002:a02:2e52:: with SMTP id u18mr29934269jae.84.1557332779112; Wed, 08 May 2019 09:26:19 -0700 (PDT) Received: from shuah-t480s.internal (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 3sm1657304itk.1.2019.05.08.09.26.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 May 2019 09:26:18 -0700 (PDT) From: Shuah Khan To: shuah@kernel.org Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests: fix install target to use default install path Date: Wed, 8 May 2019 10:26:16 -0600 Message-Id: <20190508162616.9393-1-skhan@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Install target fails when INSTALL_PATH is undefined. Fix install target to use "output_dir/install as the default install location. "output_dir" is either the root of selftests directory under kernel source tree or output directory specified by O= or KBUILD_OUTPUT. e.g: make -C tools/testing/selftests install make O=/tmp/kselftest -C tools/testing/selftests install export KBUILD_OUTPUT=/tmp/kselftest make -C tools/testing/selftests install In addition, add "all" target as dependency to "install" to build and install using a single command. Signed-off-by: Shuah Khan --- tools/testing/selftests/Makefile | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 9f05448e5e4b..c71a63b923d4 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -163,11 +163,17 @@ clean_hotplug: run_pstore_crash: make -C pstore run_crash -INSTALL_PATH ?= install +# Use $BUILD as the default install root. $BUILD points to the +# right output location for the following cases: +# 1. output_dir=kernel_src +# 2. a separate output directory is specified using O= KBUILD_OUTPUT +# 3. a separate output directory is specified using KBUILD_OUTPUT +# +INSTALL_PATH ?= $(BUILD)/install INSTALL_PATH := $(abspath $(INSTALL_PATH)) ALL_SCRIPT := $(INSTALL_PATH)/run_kselftest.sh -install: +install: all ifdef INSTALL_PATH @# Ask all targets to install their files mkdir -p $(INSTALL_PATH)/kselftest -- 2.17.1