From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Andrea Parri <andrea.parri@amarulasolutions.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Joel Fernandes <joelaf@google.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: Question about sched_setaffinity()
Date: Thu, 9 May 2019 15:17:30 -0700 [thread overview]
Message-ID: <20190509221730.GM3923@linux.ibm.com> (raw)
In-Reply-To: <20190509215505.GB5820@andrea>
On Thu, May 09, 2019 at 11:56:35PM +0200, Andrea Parri wrote:
> On Thu, May 09, 2019 at 11:40:25PM +0200, Andrea Parri wrote:
> > On Thu, May 09, 2019 at 10:36:54AM -0700, Paul E. McKenney wrote:
> > > On Tue, May 07, 2019 at 03:16:13PM -0700, Paul E. McKenney wrote:
> > > > On Wed, May 01, 2019 at 01:27:13PM -0700, Paul E. McKenney wrote:
> > > > > On Wed, May 01, 2019 at 03:16:55PM -0400, Steven Rostedt wrote:
> > > > > > On Wed, 1 May 2019 12:12:13 -0700
> > > > > > "Paul E. McKenney" <paulmck@linux.ibm.com> wrote:
> > > > > >
> > > > > >
> > > > > > > OK, what I did was to apply the patch at the end of this email to -rcu
> > > > > > > branch dev, then run rcutorture as follows:
> > > > > > >
> > > > > > > nohup tools/testing/selftests/rcutorture/bin/kvm.sh --cpus 8 --duration 2 --configs "TRIVIAL" --bootargs "trace_event=sched:sched_switch,sched:sched_wakeup ftrace=function_graph ftrace_graph_filter=sched_setaffinity,migration_cpu_stop"
> > > > > > >
> > > > > > > This resulted in the console output that I placed here:
> > > > > > >
> > > > > > > http://www2.rdrop.com/~paulmck/submission/console.log.gz
> > > > > > >
> > > > > > > But I don't see calls to sched_setaffinity() or migration_cpu_stop().
> > > > > > > Steve, is something else needed on the kernel command line in addition to
> > > > > > > the following?
> > > > > > >
> > > > > > > ftrace=function_graph ftrace_graph_filter=sched_setaffinity,migration_cpu_stop
> > > > > >
> > > > > > Do you have function graph enabled in the config?
> > > > > >
> > > > > > [ 2.098303] ftrace bootup tracer 'function_graph' not registered.
> > > > >
> > > > > I guess I don't! Thank you, will fix.
> > > > >
> > > > > Let's see...
> > > > >
> > > > > My .config has CONFIG_HAVE_FUNCTION_GRAPH_TRACER=y. It looks like I
> > > > > need CONFIG_FUNCTION_GRAPH_TRACER=y, which I don't have. And it looks
> > > > > like that needs CONFIG_FUNCTION_TRACER=y, which I also don't have.
> > > > > But I do have CONFIG_HAVE_FUNCTION_TRACER=y. So I should add this
> > > > > to my rcutorture command line:
> > > > >
> > > > > --kconfig "CONFIG_FUNCTION_TRACER=y CONFIG_FUNCTION_GRAPH_TRACER=y".
> > > > >
> > > > > I fired this up. Here is hoping! ;-)
> > > > >
> > > > > And it does have sched_setaffinity(), woo-hoo!!! I overwrote the old file:
> > > > >
> > > > > http://www2.rdrop.com/~paulmck/submission/console.log.gz
> > > >
> > > > And I reran after adding a trace_printk(), which shows up as follows:
> > > >
> > > > [ 211.409565] 6) | /* On unexpected CPU 6, expected 4!!! */
> > > >
> > > > I placed the console log here:
> > > >
> > > > http://www2.rdrop.com/~paulmck/submission/console.tpk.log.gz
> > > >
> > > > Just in case the earlier log proves useful.
> > > >
> > > > And it is acting as if the destination CPU proved to be offline. Except
> > > > that this rcutorture scenario doesn't offline anything, and I don't see
> > > > any CPU-hotplug removal messages. So I added another trace_printk() to
> > > > print out cpu_online_mask. This gets me the following:
> > > >
> > > > [ 31.565605] 0) | /* On unexpected CPU 0, expected 1!!! */
> > > > [ 31.565605] 0) | /* Online CPUs: 0-7 */
> > > >
> > > > So we didn't make it to CPU 1 despite its being online. I placed the
> > > > console log here:
> > > >
> > > > http://www2.rdrop.com/~paulmck/submission/console.tpkol.log.gz
> > > >
> > > > Thoughts?
> >
> > And I can finally see/reproduce it!!
> >
> > Frankly, no idea how this is happening (I have been staring at these
> > traces/functions for hours/days now... ;-/ )
> >
> > Adding some "sched" folks in Cc: hopefully, they can shed some light
> > about this.
>
> +Thomas, +Sebastian
>
> Thread starts here:
>
> http://lkml.kernel.org/r/20190427180246.GA15502@linux.ibm.com
Peter Zijlstra kindly volunteered over IRC to look at this more closely
tomorrow (well, today, his time). It is quite strange, though! ;-)
Thanx, Paul
> Andrea
>
>
> >
> > And yes, my only suggestion/approach would be to keep bisecting this
> > code with printk*..., 'fun' ;-/
> >
> > Andrea
>
next prev parent reply other threads:[~2019-05-09 22:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 18:02 Paul E. McKenney
2019-04-30 10:03 ` Peter Zijlstra
2019-04-30 10:51 ` Paul E. McKenney
2019-04-30 11:55 ` Peter Zijlstra
2019-05-01 19:12 ` Paul E. McKenney
2019-05-01 19:16 ` Steven Rostedt
2019-05-01 20:27 ` Paul E. McKenney
2019-05-07 22:16 ` Paul E. McKenney
2019-05-09 17:36 ` Paul E. McKenney
2019-05-09 19:36 ` Paul E. McKenney
2019-05-10 12:08 ` Peter Zijlstra
2019-05-10 23:07 ` Paul E. McKenney
2019-05-11 21:45 ` Andrea Parri
2019-05-12 0:39 ` Paul E. McKenney
2019-05-12 1:05 ` Andrea Parri
2019-05-13 12:20 ` Paul E. McKenney
2019-05-13 15:37 ` Joel Fernandes
2019-05-13 15:53 ` Paul E. McKenney
2019-05-13 8:10 ` Peter Zijlstra
2019-05-13 12:19 ` Paul E. McKenney
2019-05-09 21:40 ` Andrea Parri
2019-05-09 21:56 ` Andrea Parri
2019-05-09 22:17 ` Paul E. McKenney [this message]
2019-05-10 6:32 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509221730.GM3923@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=bigeasy@linutronix.de \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome