From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84846C04A6B for ; Fri, 10 May 2019 21:54:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54A59217F4 for ; Fri, 10 May 2019 21:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728344AbfEJVyG (ORCPT ); Fri, 10 May 2019 17:54:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:43488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727828AbfEJVyG (ORCPT ); Fri, 10 May 2019 17:54:06 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35C4F217D6; Fri, 10 May 2019 21:54:04 +0000 (UTC) Date: Fri, 10 May 2019 17:54:02 -0400 From: Steven Rostedt To: Jiri Kosina Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Peter Zijlstra , Josh Poimboeuf , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Miroslav Benes , Petr Mladek , Joe Lawrence , live-patching@vger.kernel.org, x86@kernel.org, Borislav Petkov Subject: Re: [RFC][PATCH 3/2] livepatch: remove klp_check_compiler_support() Message-ID: <20190510175402.173e0cf8@gandalf.local.home> In-Reply-To: References: <20190510163519.794235443@goodmis.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 May 2019 23:47:50 +0200 (CEST) Jiri Kosina wrote: > From: Jiri Kosina > > The only purpose of klp_check_compiler_support() is to make sure that we > are not using ftrace on x86 via mcount (because that's executed only after > prologue has already happened, and that's too late for livepatching > purposes). > > Now that mcount is not supported by ftrace any more, there is no need for > klp_check_compiler_support() either. > > Reported-by: Linus Torvalds > Signed-off-by: Jiri Kosina > --- > > I guess it makes most sense to merge this together with mcount removal in > one go. Thanks, I applied it to my queue and will start running it through my tests. -- Steve