From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66215C04A6B for ; Fri, 10 May 2019 21:58:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F4B0217D6 for ; Fri, 10 May 2019 21:58:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728337AbfEJV6r (ORCPT ); Fri, 10 May 2019 17:58:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42928 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727943AbfEJV6q (ORCPT ); Fri, 10 May 2019 17:58:46 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AA3B9308A94D; Fri, 10 May 2019 21:58:46 +0000 (UTC) Received: from treble (ovpn-123-166.rdu2.redhat.com [10.10.123.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E5BC85458D; Fri, 10 May 2019 21:58:41 +0000 (UTC) Date: Fri, 10 May 2019 16:58:39 -0500 From: Josh Poimboeuf To: Jiri Kosina Cc: Steven Rostedt , linux-kernel@vger.kernel.org, Linus Torvalds , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Miroslav Benes , Petr Mladek , Joe Lawrence , live-patching@vger.kernel.org, x86@kernel.org, Borislav Petkov Subject: Re: [RFC][PATCH 3/2] livepatch: remove klp_check_compiler_support() Message-ID: <20190510215839.obcshc5p5zapjc3c@treble> References: <20190510163519.794235443@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 10 May 2019 21:58:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2019 at 11:47:50PM +0200, Jiri Kosina wrote: > From: Jiri Kosina > > The only purpose of klp_check_compiler_support() is to make sure that we > are not using ftrace on x86 via mcount (because that's executed only after > prologue has already happened, and that's too late for livepatching > purposes). > > Now that mcount is not supported by ftrace any more, there is no need for > klp_check_compiler_support() either. > > Reported-by: Linus Torvalds > Signed-off-by: Jiri Kosina > --- > > I guess it makes most sense to merge this together with mcount removal in > one go. Acked-by: Josh Poimboeuf -- Josh