From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AADB5C04AB1 for ; Sat, 11 May 2019 15:25:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 746282183F for ; Sat, 11 May 2019 15:25:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KWhQrHEx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728663AbfEKPZW (ORCPT ); Sat, 11 May 2019 11:25:22 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60821 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728603AbfEKPZW (ORCPT ); Sat, 11 May 2019 11:25:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3BwmdeMdAB1QS2VFa71ZMNYPI8SNnkly5a4EC48lPb0=; b=KWhQrHExqVzN/YtgXR/QWdcynY LaWIhpXEXv+NFZkl5AbFbQWt8ADbQdrEmUnt4m9EYvXIV7TguX/yvxk9dJArcsl3MrocVzoPVnIpy pQmsPRqGq02vJNj6w8fHFFOntCB2a30kEdhCs6Wh9RkMwY0tLB7YmJb7k56rvFNDoxJA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hPTsF-0003fk-Jw; Sat, 11 May 2019 17:25:19 +0200 Date: Sat, 11 May 2019 17:25:19 +0200 From: Andrew Lunn To: Vicente Bergas Cc: Heiner Kallweit , Serge Semin , Russell King , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: net: phy: realtek: regression, kernel null pointer dereference Message-ID: <20190511152519.GG4889@lunn.ch> References: <16f75ff4-e3e3-4d96-b084-e772e3ce1c2b@gmail.com> <742a2235-4571-aa7d-af90-14c708205c6f@gmail.com> <11446b0b-c8a4-4e5f-bfa0-0892b500f467@gmail.com> <20190511150819.GF4889@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Andrew, > it is configured as in the vanilla kernel: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi#n191 > ,that is, > phy-mode = "rgmii"; > There are also these configuration items: > tx_delay = <0x28>; > rx_delay = <0x11>; > > Instead of going the trial-and-error way, please, can you suggest a > probably good configuration? I just found the same. Interestingly, the device tree binding says: Optional properties: - tx_delay: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default. - rx_delay: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default. So it is not using quite the default values. But there is no documentation about what these values mean. Given the difference of 0x20, it could be this is adding the needed TX delay, but not the RX delay? So you could try: rgmii-rxid And it is not clear what RX and TX mean, so also try rgmii-txid. in case they are swapped. Andrew