From: Mark Brown <broonie@kernel.org>
To: Viorel Suman <viorel.suman@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Daniel Baluta <daniel.baluta@nxp.com>,
Colin Ian King <colin.king@canonical.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Viorel Suman <viorel.suman@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: ak4458: rstn_control - return a non-zero on error only
Date: Sun, 12 May 2019 16:54:17 +0900 [thread overview]
Message-ID: <20190512075417.GG21483@sirena.org.uk> (raw)
In-Reply-To: <1557408607-25115-2-git-send-email-viorel.suman@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
On Thu, May 09, 2019 at 01:30:36PM +0000, Viorel Suman wrote:
> - return ret;
> + /* Return a negative error code only. */
> + return (ret < 0 ? ret : 0);
Please write normal conditional statements to help people who have to
read the code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-05-12 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 13:30 [PATCH 0/2] ASoC: ak4458: fail on probe if codec is not present Viorel Suman
2019-05-09 13:30 ` [PATCH 2/2] ASoC: ak4458: add return value for ak4458_probe Viorel Suman
2019-05-09 13:30 ` [PATCH 1/2] ASoC: ak4458: rstn_control - return a non-zero on error only Viorel Suman
2019-05-12 7:54 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190512075417.GG21483@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=colin.king@canonical.com \
--cc=daniel.baluta@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
--cc=viorel.suman@gmail.com \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®