From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8746CC04E53 for ; Wed, 15 May 2019 12:08:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4735920657 for ; Wed, 15 May 2019 12:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557922088; bh=2MxWDzNlNdCDBvXBg6LBRyYuiVnvhAqSwsTvAScCRDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=n3Ld5VWPGKlm7nDsdSNcUU3lzSromRjCpSuBz0MKAhGDf9EAdc1/6jaQx+w8sQcEW yIia5sX1PQqTjstJDCNZ7wNkcKVFHD/C0yNuNpzM9PrsVbLIOQ5GQr/QEJkaX9UO2m LCmGkVAAZYjK58Zo2hxxGedpvsE4xl3oK+6Xxs9g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729453AbfEOMIG (ORCPT ); Wed, 15 May 2019 08:08:06 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:38396 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729172AbfEOLI5 (ORCPT ); Wed, 15 May 2019 07:08:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ToVh8Upo0GLQhDEVaV9MC0FbfEVVYTO7nwOGlhyfbKM=; b=FKKAFpRcA4vfKWW+aLFvmH42Q UC5vKw4w7g5FDQP75Xxz2BoSkqC++3N5akLiOMlKsVDSd5ChPubvwsv9OrOIi2ksD5rOtN3FXWcR1 2+JsIq+JpZtLIc6uv7B7IzqB8Uorrvze2xNwCE4fbtCXY10Jzyg1uZFFX0aYHB9uU3hq4=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1hQrmF-0003av-Qk; Wed, 15 May 2019 11:08:51 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 320B91126D6A; Wed, 15 May 2019 12:08:51 +0100 (BST) Date: Wed, 15 May 2019 12:08:51 +0100 From: Mark Brown To: Keerthy Cc: lee.jones@linaro.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, t-kristo@ti.com Subject: Re: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support Message-ID: <20190515110851.GD5613@sirena.org.uk> References: <20190515100848.19560-1-j-keerthy@ti.com> <20190515100848.19560-4-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="q9KOos5vDmpwPx9o" Content-Disposition: inline In-Reply-To: <20190515100848.19560-4-j-keerthy@ti.com> X-Cookie: You will lose an important tape file. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --q9KOos5vDmpwPx9o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 03:38:48PM +0530, Keerthy wrote: > @@ -172,6 +178,9 @@ static int lp87565_regulator_probe(struct platform_device *pdev) > if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) { > min_idx = LP87565_BUCK_10; > max_idx = LP87565_BUCK_23; > + } else if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87561_Q1) { > + min_idx = LP87565_BUCK_3210; > + max_idx = LP87565_BUCK_3210; This if/else chain should be a switch statement. --q9KOos5vDmpwPx9o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlzb80IACgkQJNaLcl1U h9A6lAf/e30hsZKGBDMeaM6cCqdg269DLgcFARjKCZ3zp0sp3UYHDCU7I7eBAscT wMqHKpBrhHVyS6swCG7Lbsy2xywm6b77fSxxvZiWPnsdgpDHjLrzbqu2nZvA8UpD 8eXgfB8yOY1Pqw0Z9zJ55C26c+sjROltuBsJ1fGLo2HcAlSAPZtFu+zehJYKRUVq lrDGdgNGnXlxnZMVNnnAWNFCFZONW+rwZOVI9tdV8VqDX8g096T4/ZhFxVdTW3jU yMTcqq/1o12IRB26NToSf262mMa0g5ppI0k/Gq9SOFwhsi4ssXsHik2yceV0jOcA KadxC1Bmn6nfUWoNpZx2mjgylXOV8g== =dLEO -----END PGP SIGNATURE----- --q9KOos5vDmpwPx9o--