From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A89FC04E53 for ; Wed, 15 May 2019 11:40:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCF582053B for ; Wed, 15 May 2019 11:40:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557920456; bh=BeEDq+9drGLA9b20Ifn4JmEc5UMNQhx8uZ5iRD2LRBM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oRUx7msc/+nVpt8q73mfyLWRQ5K0prlU+OLJEKNC1HMyBoUVruS2m9HeM8Uj6gj4a yo3EhDe3dtIseCAn6/pndY/xcTpTJTs0drioKwdtwegiX4X2gviMOfJT2+T/fZG4gN pdUIqzqENgXezZPYHAYTvd9IJ0p/KsgTGLcaNP/I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732638AbfEOLk4 (ORCPT ); Wed, 15 May 2019 07:40:56 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:44110 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732489AbfEOL3I (ORCPT ); Wed, 15 May 2019 07:29:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=c2nb29zF7zxfX/kIeJWPumZNWap+6etEox+DI/tfr/E=; b=oKXIs7i6XSRQmXCCL9OwSOOuy pWSF/98Q3Ej9L5o9E1vHpkn4OVxa4tBNlkjcSoo5DaMKMxuu//hFb4nJ/3l9PFOALBtRVVsh/4lJc G5ewaW8I22P63tq4/U/oejQ5EtO/H9q7Xe8ipFwch4Xol801IcYTWjDNPZX76UFVbAIA4=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1hQs5k-0003dJ-PD; Wed, 15 May 2019 11:29:00 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 362941126D6A; Wed, 15 May 2019 12:29:00 +0100 (BST) Date: Wed, 15 May 2019 12:29:00 +0100 From: Mark Brown To: Sowjanya Komatineni Cc: Jonathan Hunter , "thierry.reding@gmail.com" , Laxman Dewangan , Krishna Yarlagadda , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" Subject: Re: [PATCH V5 1/4] spi: tegra114: add support for gpio based CS Message-ID: <20190515112900.GE5613@sirena.org.uk> References: <1557810235-16401-1-git-send-email-skomatineni@nvidia.com> <1557810235-16401-2-git-send-email-skomatineni@nvidia.com> <20190515093522.GC5613@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5oH/S/bF6lOfqCQb" Content-Disposition: inline In-Reply-To: X-Cookie: You will lose an important tape file. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5oH/S/bF6lOfqCQb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 15, 2019 at 11:24:22AM +0000, Sowjanya Komatineni wrote: > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier to read and reply to. > I did changed but looks like it didn't made diff. Will try with different= email client. Yeah, the behaviour is exactly the same - it's not only not wrapping your content but also reflowing quoted content. > > Please don't ignore review comments, people are generally making them > for a reason and are likely to have the same concerns if issues remain > unaddressed. Having to repeat the same comments can get repetitive and > make people question the value of time spent reviewing. If you disagree > with the review comments that's fine but you need to reply and discuss > your concerns so that the reviewer can understand your decisions. > If you are referring to comment from Jon on updating commit, I didn't ign= ored. I am just waiting if any more comments from you or others before post= ing updated patch.=20 That was more about the continuing issues with mail formatting. > But I see you applied patch now. So how should I post with updated commit? No, it's fine. It would have been better to have a clearer commit message but I think the usage makes it reasonably clear in the final code why that was done and honestly "the hardware doesn't support all the features we need to properly control devices" is an extremely common reason for using GPIO chip selects even when hardware support is available. --5oH/S/bF6lOfqCQb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlzb9/sACgkQJNaLcl1U h9BUDwf/bPfCyFuksT4NWyI8p6GWwFAUqqbX6kRmGX6QVE+z2hnkF6KlYKBRlIV6 lgYs5tiInlHAw7ZLHeqzL0i6R+OzTGprmMKnl+Tjh1JmwwVbbpe4MX2i0EM575Yo tySU55KRQjtCC9pDBjqbND2Drh7PcAQqZNnj2izJyimjcQrCNTlZaUeWDbdptqVI JInzZFPpsdvgSMMj7RTAmo22RzO2jdNNZncxo86MXp8zCvBupMDZTem3aXL9PFCJ qVP1LJ8JvHPGZcyCag9ForjT5XTHqygCSupKrqol9X2QXsJMNFMqcB5tsJkINGXk pZdS55eooHyxJvRybmtWPKzsiGJCww== =2+CF -----END PGP SIGNATURE----- --5oH/S/bF6lOfqCQb--