From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCHv2 4/4] printk: make sure we always print console disabled message
Date: Wed, 15 May 2019 16:47:02 +0200 [thread overview]
Message-ID: <20190515144702.uja2mk2vfip6maws@pathway.suse.cz> (raw)
In-Reply-To: <20190426054445.GA564@jagdpanzerIV>
On Fri 2019-04-26 14:44:45, Sergey Senozhatsky wrote:
>
> Forgot to mention that the series is still in RFC phase.
>
>
> On (04/26/19 14:33), Sergey Senozhatsky wrote:
> [..]
> > +++ b/kernel/printk/printk.c
> > @@ -2613,6 +2613,12 @@ static int __unregister_console(struct console *console)
> > pr_info("%sconsole [%s%d] disabled\n",
> > (console->flags & CON_BOOT) ? "boot" : "",
> > console->name, console->index);
> > + /*
> > + * Print 'console disabled' on all the consoles, including the
> > + * one we are about to unregister.
> > + */
> > + console_unlock();
> > + console_lock();
> >
> > res = _braille_unregister_console(console);
> > if (res)
>
> Need to think more if this is race free...
I am afraid that it is racy against for_each_console() when
removing the boot consoles.
I think that it is _not_ worth a code complication. It worked
this way for ages and people do not seem to complain.
Best Regards,
Petr
next prev parent reply other threads:[~2019-05-15 14:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 5:32 [PATCHv2 0/4] Access console drivers list under console_sem Sergey Senozhatsky
2019-04-26 5:32 ` [PATCHv2 1/4] printk: factor out __unregister_console() code Sergey Senozhatsky
2019-05-15 13:34 ` Petr Mladek
2019-04-26 5:33 ` [PATCHv2 2/4] printk: remove invalid register_console() comment Sergey Senozhatsky
2019-05-15 13:38 ` Petr Mladek
2019-04-26 5:33 ` [PATCHv2 3/4] printk: factor out register_console() code Sergey Senozhatsky
2019-05-15 14:36 ` Petr Mladek
2019-05-23 6:51 ` Sergey Senozhatsky
2019-05-27 11:42 ` Petr Mladek
2019-04-26 5:33 ` [PATCHv2 4/4] printk: make sure we always print console disabled message Sergey Senozhatsky
2019-04-26 5:44 ` Sergey Senozhatsky
2019-05-15 14:47 ` Petr Mladek [this message]
2019-05-23 6:59 ` Sergey Senozhatsky
2019-05-27 12:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515144702.uja2mk2vfip6maws@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®