From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32651C04E87 for ; Thu, 16 May 2019 07:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0270420881 for ; Thu, 16 May 2019 07:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557992837; bh=35Pcf3hpT7bW5WPrnVsVyejHjVQ2cYE9ChhCA99Y7LQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1MCuQGSlrJDvvMo6X7wwGk6AZBbBqVjtcwBcruSoSFaI4VTckWS7sD3dY/WZlGlLR mCuSq63o0b3qodDNfxtrUcprVlAOiEUW9LAqS+jZW98nf4NWdWkx2Wk8OaIYsYa3kw IN5WYcDSrNgH+2U2eeA/GUukLoSRoDbEHPMEtYwA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbfEPHrP (ORCPT ); Thu, 16 May 2019 03:47:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:50674 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726363AbfEPHrP (ORCPT ); Thu, 16 May 2019 03:47:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CECF8ADCB; Thu, 16 May 2019 07:47:13 +0000 (UTC) Date: Thu, 16 May 2019 09:47:13 +0200 From: Michal Hocko To: Greg KH Cc: Oleksandr Natalenko , linux-kernel@vger.kernel.org, Kirill Tkhai , Vlastimil Babka , Matthew Wilcox , Pavel Tatashin , Timofey Titovets , Aaron Tomlin , Grzegorz Halat , linux-mm@kvack.org, linux-api@vger.kernel.org, Hugh Dickins , Suren Baghdasaryan , Minchan Kim Subject: Re: [PATCH RFC v2 0/4] mm/ksm: add option to automerge VMAs Message-ID: <20190516074713.GK16651@dhcp22.suse.cz> References: <20190514131654.25463-1-oleksandr@redhat.com> <20190514144105.GF4683@dhcp22.suse.cz> <20190514145122.GG4683@dhcp22.suse.cz> <20190515062523.5ndf7obzfgugilfs@butterfly.localdomain> <20190515065311.GB16651@dhcp22.suse.cz> <20190515145151.GG16651@dhcp22.suse.cz> <20190515151557.GA23969@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515151557.GA23969@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 15-05-19 17:15:57, Greg KH wrote: > On Wed, May 15, 2019 at 04:51:51PM +0200, Michal Hocko wrote: > > [Cc Suren and Minchan - the email thread starts here 20190514131654.25463-1-oleksandr@redhat.com] > > > > On Wed 15-05-19 08:53:11, Michal Hocko wrote: > > [...] > > > I will try to comment on the interface itself later. But I have to say > > > that I am not impressed. Abusing sysfs for per process features is quite > > > gross to be honest. > > > > I have already commented on this in other email. I consider sysfs an > > unsuitable interface for per-process API. > > Wait, what? A new sysfs file/directory per process? That's crazy, no > one must have benchmarked it :) Just to clarify, that was not a per process file but rather per process API. Essentially echo $PID > $SYSFS_SPECIAL_FILE -- Michal Hocko SUSE Labs