From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039B6C04AAF for ; Fri, 17 May 2019 02:45:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE41420815 for ; Fri, 17 May 2019 02:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727568AbfEQCpQ (ORCPT ); Thu, 16 May 2019 22:45:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60736 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbfEQCpP (ORCPT ); Thu, 16 May 2019 22:45:15 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 962F936883; Fri, 17 May 2019 02:45:15 +0000 (UTC) Received: from xz-x1 (dhcp-15-205.nay.redhat.com [10.66.15.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACD8960A9D; Fri, 17 May 2019 02:45:12 +0000 (UTC) Date: Fri, 17 May 2019 10:45:10 +0800 From: Peter Xu To: Thomas Huth Cc: Radim =?utf-8?B?S3LEjW3DocWZ?= , Paolo Bonzini , linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, Shuah Khan , Andrew Jones , Vitaly Kuznetsov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: selftests: Compile code with warnings enabled Message-ID: <20190517024510.GN16681@xz-x1> References: <20190516130257.29445-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190516130257.29445-1-thuth@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 17 May 2019 02:45:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thomas, On Thu, May 16, 2019 at 03:02:57PM +0200, Thomas Huth wrote: > So far the KVM selftests are compiled without any compiler warnings > enabled. That's quite bad, since we miss a lot of possible bugs this > way. Let's enable at least "-Wall" and some other useful warning flags > now. > > Signed-off-by: Thomas Huth > --- > This patch fixes most of the warnings in the x86 code already - but > for some warnings, I was not quite sure (e.g. about the need for the > kvm_get_supported_cpuid_entry(1) in some tests), so I did not touch If you mean the two calls in state_test and evmcs_test I would agree they should be dropped directly. Just to mention that the patch may not apply cleanly to kvm/queue now probably because the dirty-log-test.c touchup recently, so may need a rebase. Otherwise it looks nice at least to me to have these checks. Thanks, -- Peter Xu