On Wed 2019-05-15 12:55:33, Greg Kroah-Hartman wrote: > [ Upstream commit a8fd48b50deaa20808bbf0f6685f6f1acba6a64c ] > > Preemption disabled at: > [] dev_set_rx_mode+0x1c/0x38 > Call trace: > [] dump_backtrace+0x0/0x3d0 > [] show_stack+0x14/0x20 > [] dump_stack+0xac/0xe4 > [] ___might_sleep+0x164/0x238 > [] __might_sleep+0x50/0x88 > [] kmem_cache_alloc+0x17c/0x1d0 > [] ocelot_set_rx_mode+0x108/0x188 [mscc_ocelot_common] > [] __dev_set_rx_mode+0x58/0xa0 > [] dev_set_rx_mode+0x24/0x38 > > Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") Is it right fix? Warning is gone, but now allocation is more likely to fail, causing mc_add() to fail under memory pressure. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html