From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
"open list:DRM DRIVERS FOR RENESAS"
<dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: rcar-du: writeback: include interface header
Date: Sat, 18 May 2019 20:11:29 +0300 [thread overview]
Message-ID: <20190518171129.GA4995@pendragon.ideasonboard.com> (raw)
In-Reply-To: <a61ab53c-4e05-991c-f74f-802bd6222d8a@cogentembedded.com>
Hi Sergei,
On Sat, May 18, 2019 at 11:42:28AM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 18.05.2019 0:20, Kieran Bingham wrote:
>
> > The new writeback feature is exports functions so that they can
> ^^ not needed?
Good catch. I'll fix it in my branch.
> > integrate into the rcar_du_kms module.
> >
> > The interface functions are defined in the rcar_du_writeback header, but
> > it is not included in the object file itself leading to compiler
> > warnings for missing prototypes.
> >
> > Include the header as appropriate.
> >
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> [...]
>
> MBR, Sergei
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2019-05-18 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 21:20 Kieran Bingham
2019-05-17 22:06 ` Laurent Pinchart
2019-05-18 8:42 ` Sergei Shtylyov
2019-05-18 17:11 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518171129.GA4995@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®