From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=DATE_IN_PAST_03_06, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A4BC04AB4 for ; Sun, 19 May 2019 17:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FB4620645 for ; Sun, 19 May 2019 17:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="slfu0BFz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728687AbfESRr6 (ORCPT ); Sun, 19 May 2019 13:47:58 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:39363 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbfESRr6 (ORCPT ); Sun, 19 May 2019 13:47:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nGfJ2GuiWeyt9rdjobbqK26MJz6zWpxPp9VLVvLGkgg=; b=slfu0BFzLQZn1MmTp8hvrsCDeP n2F9RinHqlueAn0CJbdWP+F9UROtNCunHcWodts0o01XtaINKnv04y3eAUwf39bsJpe5iPFvWzywb ik0VOfEmH09QalAOH1lWpLPzll0uyscXaV+v12FeXr0ykAQtOae7BXuaeuEBdzHAOrU8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hSMOl-0005Vi-PL; Sun, 19 May 2019 16:02:47 +0200 Date: Sun, 19 May 2019 16:02:47 +0200 From: Andrew Lunn To: Petr =?utf-8?Q?=C5=A0tetiar?= Cc: Rob Herring , Frank Rowand , Florian Fainelli , Heiner Kallweit , Mirko Lindner , Stephen Hemminger , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of_net: fix of_get_mac_address retval if compiled without CONFIG_OF Message-ID: <20190519140247.GB30854@lunn.ch> References: <1558268324-5596-1-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1558268324-5596-1-git-send-email-ynezz@true.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 19, 2019 at 02:18:44PM +0200, Petr Štetiar wrote: > of_get_mac_address prior to commit d01f449c008a ("of_net: add NVMEM > support to of_get_mac_address") could return only valid pointer or NULL, > after this change it could return only valid pointer or ERR_PTR encoded > error value, but I've forget to change the return value of > of_get_mac_address in case where the kernel is compiled without > CONFIG_OF, so I'm doing so now. > > Cc: Mirko Lindner > Cc: Stephen Hemminger > Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address") > Reported-by: Octavio Alvarez > Signed-off-by: Petr Štetiar Reviewed-by: Andrew Lunn Andrew