From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: Emanuel Bennici <benniciemanuel78@gmail.com>,
Vatsala Narang <vatsalanarang@gmail.com>,
Nishka Dasgupta <nishka.dasgupta@yahoo.com>,
Young Xiao <YangX92@hotmail.com>,
Aymen Qader <qader.aymen@gmail.com>,
Henriette Hofmeier <passt@h-hofmeier.de>,
Hardik Singh Rathore <hardiksingh.k@gmail.com>,
Madhumitha Prabakaran <madhumithabiw@gmail.com>,
Michael Straube <straube.linux@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: rtw_mlme_ext: fix warning Unneeded variable: "ret"
Date: Mon, 20 May 2019 10:55:39 +0200 [thread overview]
Message-ID: <20190520085539.GD19183@kroah.com> (raw)
In-Reply-To: <20190519171227.GA8089@hari-Inspiron-1545>
On Sun, May 19, 2019 at 10:42:27PM +0530, Hariprasad Kelam wrote:
> This patch fixes below warnings reported by coccicheck
>
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1888:14-17: Unneeded
> variable: "ret". Return "_FAIL" on line 1920
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:466:5-8: Unneeded
> variable: "res". Return "_SUCCESS" on line 494
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index d110d45..6a2eb66 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -463,7 +463,6 @@ static u8 init_channel_set(struct adapter *padapter, u8 ChannelPlan, RT_CHANNEL_
>
> int init_mlme_ext_priv(struct adapter *padapter)
> {
> - int res = _SUCCESS;
> struct registry_priv *pregistrypriv = &padapter->registrypriv;
> struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
> struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
> @@ -491,7 +490,7 @@ int init_mlme_ext_priv(struct adapter *padapter)
> pmlmeext->fixed_chan = 0xFF;
> #endif
>
> - return res;
> + return _SUCCESS;
If it can never fail, it should not be returning a value :(
prev parent reply other threads:[~2019-05-20 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-19 17:12 Hariprasad Kelam
2019-05-20 8:55 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520085539.GD19183@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=YangX92@hotmail.com \
--cc=benniciemanuel78@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=hardiksingh.k@gmail.com \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madhumithabiw@gmail.com \
--cc=nishka.dasgupta@yahoo.com \
--cc=passt@h-hofmeier.de \
--cc=qader.aymen@gmail.com \
--cc=straube.linux@gmail.com \
--cc=vatsalanarang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome