From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 360A7C04AB4 for ; Sun, 19 May 2019 23:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F21EF206BF for ; Sun, 19 May 2019 23:52:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="KLWMdqX3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728077AbfESXwa (ORCPT ); Sun, 19 May 2019 19:52:30 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:43525 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbfESXw3 (ORCPT ); Sun, 19 May 2019 19:52:29 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 456f2v36tzz9s3l; Mon, 20 May 2019 09:52:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1558309947; bh=CN+zUAW7OwrDo7b3+A0y27+2RgfK+dCSNj3fDYj5c/o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KLWMdqX3q2GjGb8rS1H4yu5B66Y2F0UCJLrwYbqmn55nq1eog30th+/LamoCIyfZV b45wGB3lG8D/lrMeaBLGkELdaKUgfeR1MvUTusdwGh4K8ymN9RowZSmlRcNgaF1xgn rVwCvGTaUBkEqA3R7PQVyJks9pvpnD5rRhAKRPV/xwKykP6xqFf+cKNV1i/T8Awf1z JsmVrcYswYISVSjpqqQmIFTDON1fJXyomrAHyXzbzOeySkHHXIfiXZuq9OLjpJuJB9 1K+wz9qf5lNwu5TXcmY4tEskL6xxqgwC2H2penssx/qH66qxqRUf96zCCX/9OhghnE uTvI+AppETxeA== Date: Mon, 20 May 2019 09:51:47 +1000 From: Stephen Rothwell To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Greg Kroah-Hartman , Arnd Bergmann , Jessica Yu , Lucas De Marchi , Michael Schmitz , Linus Torvalds , Rusty Russell , Kees Cook , Bernd Petrovitsch , Alexander Kapshuk , Sam Ravnborg , Michal Marek , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] kbuild: check uniqueness of module names Message-ID: <20190520095147.2021c218@canb.auug.org.au> In-Reply-To: <1558109235-23042-1-git-send-email-yamada.masahiro@socionext.com> References: <1558109235-23042-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/A_/Ly4YcWk_rggvMudJw4JL"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/A_/Ly4YcWk_rggvMudJw4JL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Masahiro, On Sat, 18 May 2019 01:07:15 +0900 Masahiro Yamada wrote: > > It checks not only real modules, but also built-in modules (i.e. > controlled by tristate CONFIG option, but currently compiled with =3Dy). > Non-unique names for built-in modules also cause problems because > /sys/modules/ would fall over. >=20 > I tested allmodconfig on the latest kernel, and it detected the > following: A powerpc ppc64_defconfig produces: warning: same basename if the following are built as modules: arch/powerpc/platforms/powermac/nvram.ko drivers/char/nvram.ko Which is a false positive since arch/powerpc/platforms/powermac/Makefile has # CONFIG_NVRAM is an arch. independent tristate symbol, for pmac32 we really # need this to be a bool. Cheat here and pretend CONFIG_NVRAM=3Dm is really # CONFIG_NVRAM=3Dy obj-$(CONFIG_NVRAM:m=3Dy) +=3D nvram.o Which means that this nvram.o will never be built as a module. --=20 Cheers, Stephen Rothwell --Sig_/A_/Ly4YcWk_rggvMudJw4JL Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlzh7BMACgkQAVBC80lX 0GyXcgf9EHJI02d2q9r16RMZuwm83yJam/fLG3wWJjYoNeqZN1QuJCMSh/CtISaw 5K2E78DMOAx7Y0FnYqNXNL7AfMATfcXJ33hfHwSu3fN9ImLt7lx7vFPKjruguAT/ KsUQRp4NWg8nlsJCDQNtzisn/vQzOzKI5kxCeExTWExBAvlgQLTebfS7JOc7srYo 1tS139kml2TScMTpaCI9bFGsIfd991j83eKttcDAJODcb2EJwaC+kuOH1hp6eg9z upbDSjJtkQvyvEo4acV5hlDVF+sMfHoJFPCXfzR8XNAAuALwuoz1fzCYN+28h7zM a1xxsfX5ZUMnufVrPRp+O7o34QFn8Q== =9a7G -----END PGP SIGNATURE----- --Sig_/A_/Ly4YcWk_rggvMudJw4JL--