From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF2C9C04AB4 for ; Mon, 20 May 2019 00:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD8DD20815 for ; Mon, 20 May 2019 00:04:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="iB3S1IwJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729526AbfETAEm (ORCPT ); Sun, 19 May 2019 20:04:42 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:43469 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727720AbfETAEl (ORCPT ); Sun, 19 May 2019 20:04:41 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 456fK20cjwz9s3l; Mon, 20 May 2019 10:04:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1558310678; bh=pZcgB5aQrClEmkJbHCnZA6xWxdkeqKTCyUtTxpH7sYo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iB3S1IwJZiOzvGM5FdZcY27eyAoaF+65n6TlJ9euu6Of0clySD0G5GeGZiKE5MO6F UQfUFzXDeuXwYsiQiyqrMTyA0VCFuDSvvqvMaxitNuH2RXnRw8QAWVCr4xw/DbBwy9 e5HAgj4xLTwORdq7uoJrFsQToiVc6qDVVbBBcvYIYrrISDVm/Vli3Y4SgMmOuK0d39 QSeqHHgN7e+BuCXLsDlkiTDFhGmmWBryXldImwetipuacYwbj2G9CVdUujkNsiZecc /nW83IIFnhInicDqmKjVeZcUJ9Gsb0wBOY+yDHoDTLSRyjrNC+bFuwxGz+teBnPe7b frLaXys4o9xxQ== Date: Mon, 20 May 2019 10:04:37 +1000 From: Stephen Rothwell To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Greg Kroah-Hartman , Arnd Bergmann , Jessica Yu , Lucas De Marchi , Michael Schmitz , Linus Torvalds , Rusty Russell , Kees Cook , Bernd Petrovitsch , Alexander Kapshuk , Sam Ravnborg , Michal Marek , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] kbuild: check uniqueness of module names Message-ID: <20190520100437.54142214@canb.auug.org.au> In-Reply-To: <1558109235-23042-1-git-send-email-yamada.masahiro@socionext.com> References: <1558109235-23042-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/3dAX7L8JPnsN0p+_o1m6Pq5"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/3dAX7L8JPnsN0p+_o1m6Pq5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Masahiro, On Sat, 18 May 2019 01:07:15 +0900 Masahiro Yamada wrote: >=20 > +++ b/scripts/modules-check.sh > @@ -0,0 +1,16 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > + > +set -e > + > +# Check uniqueness of module names > +check_same_name_modules() > +{ > + for m in $(sed 's:.*/::' modules.order modules.builtin | sort | uniq -d) > + do > + echo "warning: same basename if the following are built as modules:" >= &2 > + sed "/\/$m/!d;s:^kernel/: :" modules.order modules.builtin >&2 (bringing out my bike shed paint brush :-)) this could be sed -n "/\/$m/s:^kernel/: :p" ... --=20 Cheers, Stephen Rothwell --Sig_/3dAX7L8JPnsN0p+_o1m6Pq5 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlzh7xUACgkQAVBC80lX 0GxtuQf/XV73OxF/ig8/6h1gF16geBlX31hBIHbQ/lqzfZ02xQ98N6dzkDP72cvK HAblUyWj3ZeGB6x4OASl1wCNHdRTFr5ex/422Si65InuHCelpVBYRqq6PfMljCKg pAaDVJ5+IUmlkMN/gSsvhJCdEaZ+5IS/C3k7TH2P1XNLaTe9C+LHpWNQfKeypmIZ MuFd9ufZ2bdSRUhmmoctBfDv35ErEJu9I4+bup2/E4K/AkTvv6Ux0s7EAPJYnP3Z c97dMHwaMUQoHlgmTHTVTCWP7ckpc/jPleu8Yyr7SQlzOPt+UIqsqKnDcb5ioAGZ YbrwTkP7ORCZv2fSxLpA/1V9/e1MKQ== =ycTi -----END PGP SIGNATURE----- --Sig_/3dAX7L8JPnsN0p+_o1m6Pq5--