From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E34AC04AAC for ; Mon, 20 May 2019 11:31:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33F1220644 for ; Mon, 20 May 2019 11:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732889AbfETLbV (ORCPT ); Mon, 20 May 2019 07:31:21 -0400 Received: from torres.zugschlus.de ([85.214.131.164]:44980 "EHLO torres.zugschlus.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731119AbfETLbV (ORCPT ); Mon, 20 May 2019 07:31:21 -0400 Received: from mh by torres.zugschlus.de with local (Exim 4.92) (envelope-from ) id 1hSgVj-0002sD-PI; Mon, 20 May 2019 13:31:19 +0200 Date: Mon, 20 May 2019 13:31:19 +0200 From: Marc Haber To: Florian Westphal Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: Kernel 5.1 breaks UDP checksums for SIP packets Message-ID: <20190520113119.GB6502@torres.zugschlus.de> References: <20190520094955.GA6502@torres.zugschlus.de> <20190520102802.vv3xyd2p7ei4j65r@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190520102802.vv3xyd2p7ei4j65r@breakpoint.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 12:28:02PM +0200, Florian Westphal wrote: > Marc Haber wrote: > > when I update my Firewall from Kernel 5.0 to Kernel 5.1, SIP clients > > that connect from the internal network to an external, commercial SIP > > service do not work any more. When I trace beyond the NAT, I see that > > the outgoing SIP packets have incorrect UDP checksums: > > I'm a moron. Can you please try this patch? > > diff --git a/net/netfilter/nf_nat_helper.c b/net/netfilter/nf_nat_helper.c > --- a/net/netfilter/nf_nat_helper.c > +++ b/net/netfilter/nf_nat_helper.c > @@ -170,7 +170,7 @@ nf_nat_mangle_udp_packet(struct sk_buff *skb, > if (!udph->check && skb->ip_summed != CHECKSUM_PARTIAL) > return true; > > - nf_nat_csum_recalc(skb, nf_ct_l3num(ct), IPPROTO_TCP, > + nf_nat_csum_recalc(skb, nf_ct_l3num(ct), IPPROTO_UDP, > udph, &udph->check, datalen, oldlen); > > return true; Thanks for the lightning fast reaction. The patch indeed fixes the issue for me, everything is online now, incoming and outgoing calls are possible. Can you funnel that one to Greg please for the next stable release? Greetings Marc -- ----------------------------------------------------------------------------- Marc Haber | "I don't trust Computers. They | Mailadresse im Header Leimen, Germany | lose things." Winona Ryder | Fon: *49 6224 1600402 Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421