From: Christoph Hellwig <hch@infradead.org>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v4 2/2] RISC-V: Setup initial page tables in two stages
Date: Mon, 20 May 2019 04:43:52 -0700 [thread overview]
Message-ID: <20190520114352.GA5372@infradead.org> (raw)
In-Reply-To: <20190502050206.23373-3-anup.patel@wdc.com>
> void __init parse_dtb(unsigned int hartid, void *dtb)
> {
> - if (early_init_dt_scan(__va(dtb)))
> + dtb = (void *)fix_to_virt(FIX_FDT) + ((uintptr_t)dtb & ~PAGE_MASK);
> + if (early_init_dt_scan(dtb))
FYI, parse_dtb in mainline now lost the hartid argument and takes a
phys_addr_t for the dtb address.
That being said I find the above way to magic. So we take the fixmap
address and then only the offset from something passed as a pointer?
This just looks very weird. The way FIX_FDT is defined to add to my
confusion, which might partially be due to not understanding fixmaps
very well. But it seems like at very least we should set up an
actual kernel pointer for the dtb in setup_vm based on what that
gets passed and stop passing any arguments to parse_dtb to keep
that magic in one place. And possibly add some comment.
> +#if MAX_EARLY_MAPPING_SIZE < PGDIR_SIZE
It seems MAX_EARLY_MAPPING_SIZE is defined to a fix constant,
why do we need these conditionals?
next prev parent reply other threads:[~2019-05-20 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 5:02 [PATCH v4 0/2] Two-stagged initial page table setup Anup Patel
2019-05-02 5:02 ` [PATCH v4 1/2] RISC-V: Fix memory reservation in setup_bootmem() Anup Patel
2019-05-02 5:02 ` [PATCH v4 2/2] RISC-V: Setup initial page tables in two stages Anup Patel
2019-05-20 11:43 ` Christoph Hellwig [this message]
2019-05-21 7:38 ` Anup Patel
2019-05-20 8:44 ` [PATCH v4 0/2] Two-stagged initial page table setup Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520114352.GA5372@infradead.org \
--to=hch@infradead.org \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome