From: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Cc: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Quentin Deslandes <quentin.deslandes@itdev.co.uk>,
Mukesh Ojha <mojha@codeaurora.org>,
Ojaswin Mujoo <ojaswin25111998@gmail.com>,
Nishad Kamdar <nishadkamdar@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/7] staging: vt6656: clean-up error path on init
Date: Mon, 20 May 2019 16:39:00 +0000 [thread overview]
Message-ID: <20190520163844.1225-1-quentin.deslandes@itdev.co.uk> (raw)
This patchset aims to cleanup vt6656 driver's error path during the
initialization process.
During a call to vnt_start(), none of the functions called would return
a meaningful error code nor handle the one returned from the functions
they call themselves.
The first patch of the series fixes a potential NULL pointer dereferencing.
All the other patches update function's error management workflow and prototype
when needed.
More functions would need to be updated, but focusing on initialization
process force to change only a reasonable amount of code.
Thank you,
Quentin
Quentin Deslandes (7):
staging: vt6656: fix potential NULL pointer dereference
staging: vt6656: clean function's error path in usbpipe.c
staging: vt6656: avoid discarding called function's return code
staging: vt6656: clean error path for firmware management
staging: vt6656: use meaningful error code during buffer allocation
staging: vt6656: clean-up registers initialization error path
staging: vt6656: manage error path during device initialization
drivers/staging/vt6656/baseband.c | 130 +++++++++++------
drivers/staging/vt6656/baseband.h | 8 +-
drivers/staging/vt6656/card.c | 20 ++-
drivers/staging/vt6656/firmware.c | 91 ++++++------
drivers/staging/vt6656/int.c | 8 +-
drivers/staging/vt6656/int.h | 2 +-
drivers/staging/vt6656/mac.c | 19 ++-
drivers/staging/vt6656/mac.h | 6 +-
drivers/staging/vt6656/main_usb.c | 230 ++++++++++++++++++------------
drivers/staging/vt6656/rf.c | 38 +++--
drivers/staging/vt6656/rf.h | 2 +-
drivers/staging/vt6656/usbpipe.c | 115 ++++++++-------
drivers/staging/vt6656/usbpipe.h | 4 +-
13 files changed, 400 insertions(+), 273 deletions(-)
--
2.17.1
next reply other threads:[~2019-05-20 16:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 16:39 Quentin Deslandes [this message]
2019-05-20 16:39 ` [PATCH 1/7] staging: vt6656: fix potential NULL pointer dereference Quentin Deslandes
2019-05-20 16:39 ` [PATCH 2/7] staging: vt6656: clean function's error path in usbpipe.c Quentin Deslandes
2019-05-20 16:39 ` [PATCH 3/7] staging: vt6656: avoid discarding called function's return code Quentin Deslandes
2019-05-20 16:39 ` [PATCH 4/7] staging: vt6656: clean error path for firmware management Quentin Deslandes
2019-05-20 16:39 ` [PATCH 5/7] staging: vt6656: use meaningful error code during buffer allocation Quentin Deslandes
2019-05-20 16:39 ` [PATCH 6/7] staging: vt6656: clean-up registers initialization error path Quentin Deslandes
2019-05-21 6:24 ` Greg Kroah-Hartman
2019-05-20 16:39 ` [PATCH 7/7] staging: vt6656: manage error path during device initialization Quentin Deslandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520163844.1225-1-quentin.deslandes@itdev.co.uk \
--to=quentin.deslandes@itdev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
--cc=nishadkamdar@gmail.com \
--cc=ojaswin25111998@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®