From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E269C04AAC for ; Mon, 20 May 2019 19:05:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67240205ED for ; Mon, 20 May 2019 19:05:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="d1TmZCCk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726198AbfETTFm (ORCPT ); Mon, 20 May 2019 15:05:42 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40921 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbfETTFm (ORCPT ); Mon, 20 May 2019 15:05:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hr/1iGRppucKUPs7Jd/NpqKBvJMNwEtcN7Vo/hR52/Y=; b=d1TmZCCktRBG0kT3B2zm851Rcq Oq8vGbMMGgpwEBZ9ZdSa5IHBD/v5MLv5h9tM6dI1VVWjQlDc5+N8VGv7b95g762H67pv4Xw0v0852 hrkH2UWVrEPyYE7JTy1tlvY2fDG41ksB4Nyk7ShaeXNwLx6lYORQHCHkvryzT9ximM2M=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hSnbJ-0002qk-7O; Mon, 20 May 2019 21:05:33 +0200 Date: Mon, 20 May 2019 21:05:33 +0200 From: Andrew Lunn To: Martin Blumenstingl Cc: Jerome Brunet , Kevin Hilman , devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, hkallweit1@gmail.com Subject: Re: [PATCH v2 3/5] arm64: dts: meson: g12a: add mdio multiplexer Message-ID: <20190520190533.GF22024@lunn.ch> References: <20190520131401.11804-1-jbrunet@baylibre.com> <20190520131401.11804-4-jbrunet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + int_mdio: mdio@1 { > > + reg = <1>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + internal_ephy: ethernet_phy@8 { > > + compatible = "ethernet-phy-id0180.3301", > > + "ethernet-phy-ieee802.3-c22"; > Based on your comment on v1 of this patch [0] the Ethernet PHY ID is > defined by this "mdio-multiplexer" (write arbitrary value to a > register then that's the PHY ID which will show up on the bus) > I'm fine with explicitly listing the ID which the PHY driver binds to > because I don't know a better way. Does reading the ID registers give the correct ID, once you have poked registers in the mdio-multiplexer? If so, you don't need this compatible string. If the read is giving the wrong ID, then yes, you do want this. But then please add a comment in the DT blob. This is very unusual, so should have some explanation why it is needed. Thanks Andrew