From: Steven Rostedt <rostedt@goodmis.org>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
paulmck@linux.ibm.com, josh@joshtriplett.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
joel@joelfernandes.org, corbet@lwn.net, tglx@linutronix.de,
mingo@kernel.org, gregkh@linuxfoundation.org,
keescook@chromium.org, srinivas.eeda@oracle.com
Subject: Re: [PATCH v2] doc: kernel-parameters.txt: fix documentation of nmi_watchdog parameter
Date: Tue, 21 May 2019 08:56:27 -0400 [thread overview]
Message-ID: <20190521085627.0b36cd80@gandalf.local.home> (raw)
In-Reply-To: <064f1230-be51-37ef-9283-69a7277fdd67@oracle.com>
On Tue, 21 May 2019 17:42:28 +0800
Zhenzhong Duan <zhenzhong.duan@oracle.com> wrote:
> On 2019/5/15 3:21, Steven Rostedt wrote:
> > On Sun, 12 May 2019 11:35:27 +0800
> > Zhenzhong Duan <zhenzhong.duan@oracle.com> wrote:
> >
> >> The default behavior of hardlockup depends on the config of
> >> CONFIG_BOOTPARAM_HARDLOCKUP_PANIC.
> >>
> >> Fix the description of nmi_watchdog to make it clear.
> >>
> >> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> >> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> >> Cc: Steven Rostedt <rostedt@goodmis.org>
> > Perhaps it should have been:
> >
> > Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > As the wording is what I suggested ;-)
>
> Sure, I should have done that. Just not familiar with which one is better.
>
> Not clear if I should send a v3 adding Suggested-by and Acked-by?
Yep, it's fine to add both:
Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
>
> Zhenzhong
prev parent reply other threads:[~2019-05-21 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 3:35 Zhenzhong Duan
2019-05-14 7:09 ` Ingo Molnar
2019-05-14 19:21 ` Steven Rostedt
2019-05-21 9:42 ` Zhenzhong Duan
2019-05-21 12:56 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521085627.0b36cd80@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=srinivas.eeda@oracle.com \
--cc=tglx@linutronix.de \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®