From: Michal Hocko <mhocko@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org,
catalin.marinas@arm.com, will.deacon@arm.com,
mark.rutland@arm.com, ira.weiny@intel.com, david@redhat.com,
cai@lca.pw, logang@deltatee.com, james.morse@arm.com,
cpandya@codeaurora.org, arunks@codeaurora.org,
dan.j.williams@intel.com, mgorman@techsingularity.net,
osalvador@suse.de, ard.biesheuvel@arm.com
Subject: Re: [PATCH V4 3/4] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump
Date: Tue, 21 May 2019 12:14:57 +0200 [thread overview]
Message-ID: <20190521101457.GK32329@dhcp22.suse.cz> (raw)
In-Reply-To: <1558329516-10445-4-git-send-email-anshuman.khandual@arm.com>
On Mon 20-05-19 10:48:35, Anshuman Khandual wrote:
> The arm64 page table dump code can race with concurrent modification of the
> kernel page tables. When a leaf entries are modified concurrently, the dump
> code may log stale or inconsistent information for a VA range, but this is
> otherwise not harmful.
>
> When intermediate levels of table are freed, the dump code will continue to
> use memory which has been freed and potentially reallocated for another
> purpose. In such cases, the dump code may dereference bogus addresses,
> leading to a number of potential problems.
>
> Intermediate levels of table may by freed during memory hot-remove,
> which will be enabled by a subsequent patch. To avoid racing with
> this, take the memory hotplug lock when walking the kernel page table.
I've had a comment on this patch in the previous version which didn't
get answered completely AFAICS. If you really insist then please make
sure to describe why does this really matter because this will make
any further changes to the hotplug locking harder and I would to see
that it is worth the additional trouble.
Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-05-21 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 5:18 [PATCH V4 0/4] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-05-20 5:18 ` [PATCH V4 1/4] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory() Anshuman Khandual
2019-05-20 5:18 ` [PATCH V4 2/4] arm64/mm: Inhibit huge-vmap with ptdump Anshuman Khandual
2019-05-20 5:18 ` [PATCH V4 3/4] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump Anshuman Khandual
2019-05-21 10:14 ` Michal Hocko [this message]
2019-05-24 4:52 ` Anshuman Khandual
2019-05-20 5:18 ` [PATCH V4 4/4] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-05-21 10:20 ` David Hildenbrand
2019-05-27 8:09 ` Anshuman Khandual
2019-05-27 10:21 ` David Hildenbrand
2019-05-27 10:21 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521101457.GK32329@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ard.biesheuvel@arm.com \
--cc=arunks@codeaurora.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®