mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Oscar Gomez Fuente <oscargomezf@gmail.com>,
	devel@driverdev.osuosl.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
Date: Tue, 21 May 2019 16:17:15 +0200	[thread overview]
Message-ID: <20190521141715.GA25603@kroah.com> (raw)
In-Reply-To: <CAGngYiVNQrr2nKfGCdi8FzS5UnmGaDj_Gu_F0ZeOTMKX6_1Zuw@mail.gmail.com>

On Tue, May 21, 2019 at 10:13:58AM -0400, Sven Van Asbroeck wrote:
> On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
> <oscargomezf@gmail.com> wrote:
> >
> > These changes solve a warning realated to an incorrect type inilizer in the function
> > fieldbus_poll.
> >
> > Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
> > ---
> 
> I've reviewed your patch and tested it on a live system. Everything looks good.
> However, I believe that your commit message could be improved.
> 
> I am going to re-post this patch as v3 (keeping you as the author) but with
> a (hopefully) improved commit message. If you provide positive feedback,
> and nobody else has any comments, I will tag it with my Reviewed-by,
> which will hopefully be Greg's cue to take the patch.

Greg already took this patch a while ago :)

thanks,

greg k-h

  reply	other threads:[~2019-05-21 14:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 17:49 Oscar Gomez Fuente
2019-05-20 18:35 ` Sven Van Asbroeck
2019-05-20 19:39   ` Sven Van Asbroeck
2019-05-20 19:59     ` Oscar Gomez Fuente
2019-05-21 14:13 ` Sven Van Asbroeck
2019-05-21 14:17   ` Greg KH [this message]
2019-05-21 14:24     ` Sven Van Asbroeck
2019-05-21 14:51       ` Oscar Gomez Fuente
  -- strict thread matches above, loose matches on Subject: below --
2019-05-17 16:53 Oscar Gomez Fuente
2019-05-17 17:08 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521141715.GA25603@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oscargomezf@gmail.com \
    --cc=thesven73@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome