From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Oscar Gomez Fuente <oscargomezf@gmail.com>,
devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: fieldbus: core: fix ->poll() annotation
Date: Tue, 21 May 2019 17:37:30 +0300 [thread overview]
Message-ID: <20190521143730.GJ31203@kadam> (raw)
In-Reply-To: <20190521142009.7331-1-TheSven73@gmail.com>
On Tue, May 21, 2019 at 10:20:09AM -0400, Sven Van Asbroeck wrote:
> From: Oscar Gomez Fuente <oscargomezf@gmail.com>
>
> ->poll() functions should return __poll_t, but the fieldbus
> core's poll() does not. This generates a sparse warning.
>
> Fix the ->poll() return value, and use recommended __poll_t
> constants (EPOLLxxx).
>
> Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
> ---
If you're resending someone's patch, you have to add your own Signed off
by line as well. Everyone who touches a patch has to sign that they
didn't add any of SCO's all powerful UnixWare source code into the
patch.
regards,
dan carpenter
next prev parent reply other threads:[~2019-05-21 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 14:20 Sven Van Asbroeck
2019-05-21 14:24 ` Sven Van Asbroeck
2019-05-21 14:37 ` Dan Carpenter [this message]
2019-05-21 14:44 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521143730.GJ31203@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oscargomezf@gmail.com \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®