From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 652A5C18E7C for ; Wed, 22 May 2019 01:53:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B9EF217D9 for ; Wed, 22 May 2019 01:53:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LQZb/vjK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728183AbfEVBxr (ORCPT ); Tue, 21 May 2019 21:53:47 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:33278 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727208AbfEVBxr (ORCPT ); Tue, 21 May 2019 21:53:47 -0400 Received: by mail-pg1-f193.google.com with SMTP id h17so461346pgv.0 for ; Tue, 21 May 2019 18:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=LlxRyT+mbsnTVNTKSITBJmRiSrxfctVw8atQ9aC4s90=; b=LQZb/vjKAJSs4KcX5G91N4TfJF4lnwNCerToC7NPX0ZiF1SeZmnFrgslAo/Ehj7Ays vTcCigfoicBqFk3/cFD25tDvPYKCmuopKzOB9wZjNGLQMLqTfqSMXsx5xkIp+TMIwZ9p /aXA51kU0Nw4LB1636JvDgComqQYYS4O/aMmzkr0gDOAEC12uRDf2ha+OI7/Z3OsqBol +FaAMtdRYzoIKo+08tsZE0kpHNdsf/Cu9bAGhJwVHeDBpxKDY4Mz182jLQLSO5yH6hoI EQSNJLOUtcDP930SVt0p2UpKO/ZuX2YeviTNEAGqBjGHhI05Yul6Y345Nfg4CEuAk8gr feiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LlxRyT+mbsnTVNTKSITBJmRiSrxfctVw8atQ9aC4s90=; b=KseNBZKkWZmfIBg11bsYlRUW+PovN08ggmUtgvVfIN/OJw1dC4eTz1ivzVgG5lvxCS fMonrgjtonyxazHrzqxQke0xOA+9LbSP4uRlLk9atOm/eOsp4+GynIKdzYZz43Rjm+d6 HbFeyB5W8qFQSjEWM0qADPFvyYeZ7w6AZNfDbVC6IlKKUOP7jy0YW7/9s37hFSOV+17y uj59iPuttV8iZOsHDVHR8aezKvGPOI+DO8k7QDFV/Od7q+eENFRJ24X8Q/WF/tIVH/VG 8YvZebtr8RrAofuTMDSmCmS9MHuenJR4wMn0BrVGEwg5NAGgccWvq+eM3bVZFB6wvBU+ o+4Q== X-Gm-Message-State: APjAAAXcUuSFnGGt+B6HuC3ZKvtF6w/YIpNP7KqPR7p7jn7jDqs0UEBp GPoxrquqTS0N87LDPWtIJx1Afw== X-Google-Smtp-Source: APXvYqwErOiQXUAm3LtR1L1z9k+pkiWT1RA4VF+qZwNsLRF4A82r6eTtgvGC90jKTyxYHpvWhI1kmA== X-Received: by 2002:a63:700b:: with SMTP id l11mr30923085pgc.449.1558490026123; Tue, 21 May 2019 18:53:46 -0700 (PDT) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id i27sm47073805pfk.162.2019.05.21.18.53.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2019 18:53:45 -0700 (PDT) From: Bjorn Andersson To: Andy Gross , Rob Herring , Mark Rutland Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org Subject: [PATCH] soc: qcom: apr: Don't use reg for domain id Date: Tue, 21 May 2019 18:53:42 -0700 Message-Id: <20190522015342.29501-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The reg property represents the address and size on the bus that a device lives, but for APR the parent is a rpmsg bus, which does not have numerical addresses. Simply defining #address/#size-cells to 1 and 0, respectively, to silence the compiler is not an appropriate solution. Replace the use of "reg" with an APR specific property. Signed-off-by: Bjorn Andersson --- The APR device was recently added to msm8996.dtsi, but this is still depending on working SMMU to provide functional audio support. Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt | 2 +- drivers/soc/qcom/apr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt index bcc612cc7423..38d3c06abc41 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt @@ -9,7 +9,7 @@ used for audio/voice services on the QDSP. Value type: Definition: must be "qcom,apr-v", example "qcom,apr-v2" -- reg +- qcom,apr-domain Usage: required Value type: Definition: Destination processor ID. diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c index 74f8b9607daa..b83d71b2e0a4 100644 --- a/drivers/soc/qcom/apr.c +++ b/drivers/soc/qcom/apr.c @@ -276,7 +276,7 @@ static int apr_probe(struct rpmsg_device *rpdev) if (!apr) return -ENOMEM; - ret = of_property_read_u32(dev->of_node, "reg", &apr->dest_domain_id); + ret = of_property_read_u32(dev->of_node, "qcom,apr-domain", &apr->dest_domain_id); if (ret) { dev_err(dev, "APR Domain ID not specified in DT\n"); return ret; -- 2.18.0