From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Viktor Rosendahl <viktor.rosendahl@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Joel Fernandes <joel@joelfernandes.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency
Date: Wed, 22 May 2019 10:43:32 -0400 [thread overview]
Message-ID: <20190522104332.3564e82f@gandalf.local.home> (raw)
In-Reply-To: <20190522143545.GG16275@worktop.programming.kicks-ass.net>
On Wed, 22 May 2019 16:35:45 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> > @@ -284,6 +285,7 @@ static void do_idle(void)
> > smp_mb__after_atomic();
> >
> > sched_ttwu_pending();
> > + /* schedule_idle() will call trace_enable_fsnotify() */
> > schedule_idle();
> >
> > if (unlikely(klp_patch_pending(current)))
>
> I still hate this.. why are we doing this? We already have this
> stop_critical_timings() nonsense and are now adding more gunk.
I was thinking that this can possibly be added in the
stop_critical_timings() as that is probably where this is needed
anyway.
-- Steve
next prev parent reply other threads:[~2019-05-22 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 20:34 [PATCH v4 0/4] Some new features for the latency tracers Viktor Rosendahl
2019-05-17 20:34 ` [PATCH v4 1/4] ftrace: Implement fs notification for tracing_max_latency Viktor Rosendahl
2019-05-21 16:01 ` Steven Rostedt
2019-05-22 0:30 ` Viktor Rosendahl
2019-05-22 1:09 ` Steven Rostedt
2019-05-22 14:35 ` Peter Zijlstra
2019-05-22 14:43 ` Steven Rostedt [this message]
2019-05-22 14:31 ` Peter Zijlstra
2019-05-17 20:34 ` [PATCH v4 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger Viktor Rosendahl
2019-05-17 20:34 ` [PATCH v4 3/4] Add the latency-collector to tools Viktor Rosendahl
2019-05-17 20:34 ` [PATCH v4 4/4] ftrace: Add an option for tracing console latencies Viktor Rosendahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522104332.3564e82f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viktor.rosendahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®