From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD07C282DE for ; Thu, 23 May 2019 16:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C00C217D4 for ; Thu, 23 May 2019 16:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731533AbfEWQSS (ORCPT ); Thu, 23 May 2019 12:18:18 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48320 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730860AbfEWQSP (ORCPT ); Thu, 23 May 2019 12:18:15 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EB6B81509B028; Thu, 23 May 2019 09:18:14 -0700 (PDT) Date: Thu, 23 May 2019 09:18:14 -0700 (PDT) Message-Id: <20190523.091814.750814773629903183.davem@davemloft.net> To: Jose.Abreu@synopsys.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Joao.Pinto@synopsys.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, clabbe.montjoie@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next 00/18] net: stmmac: Improvements and Selftests From: David Miller In-Reply-To: <20190523.090928.974790678055823460.davem@davemloft.net> References: <20190523.090928.974790678055823460.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 May 2019 09:18:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Miller Date: Thu, 23 May 2019 09:09:28 -0700 (PDT) > Series applied. I'm reverting, this doesn't even build. ERROR: "dev_set_rx_mode" [drivers/net/ethernet/stmicro/stmmac/stmmac.ko] undefined! make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1 make: *** [Makefile:1290: modules] Error 2 Always test your driver both modular and static when referencing new symbols.