From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3DC6C282DD for ; Thu, 23 May 2019 15:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A61152133D for ; Thu, 23 May 2019 15:41:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="lFyCpp4T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731063AbfEWPlv (ORCPT ); Thu, 23 May 2019 11:41:51 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:43043 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730790AbfEWPlv (ORCPT ); Thu, 23 May 2019 11:41:51 -0400 Received: by mail-qt1-f196.google.com with SMTP id g17so1193337qtq.10 for ; Thu, 23 May 2019 08:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0TsHr4jNVrFLZQLBUCR+FrMQge3L+UP+h42ztox37hc=; b=lFyCpp4To4CeKZoF5gLn2kPrtZIAdF5TSSMV1WQY6giKDSOKYm5rgMAFDOtpmliUiu cCximb+BLdj7cICGvLdBf1flJHBp6CpoBiQOuwBUaxdviSxaMZXQ9e/0yyTBn9zqGApV J0AVKUNUEHJo3mxyGej6O5dQBXszIg17+BPM3pbBBFko/pdfYKerg86ew5Us0oU7Z8l4 nfx7I+Qk6qj2AXE+02nseMM2D11o9O6Bk6QmkeLzmNuDhwewsAhycJnBySXRPp7qiDcn AAdhbfk7CFjyU+4GUIxZAs2MMw10A04GGlWRStBk9yYmpkt3Jn7Xld+WJd/DKrRU3IeA XZCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0TsHr4jNVrFLZQLBUCR+FrMQge3L+UP+h42ztox37hc=; b=oKjAbJB8Xxd/FEM0hWWEiBbq2gF06H981/cszGWt2yE0qPkFPMnu/OujnRS+dq+PNy ZuyaLb4/sVR3sQF/h0OPnPdOgOMalwryBAjLPGdOAW20gcMiAr+VkSzukCfC6OxAEvcx rXAogtYXM+bQZnHKRoSOgf61d+82U1tLjLchEwMiJ0YgBFrplm4huL28nG7PXiXIgg7n KQ41ZfDvjBAY88ET+DMKaU/gb4VenYE3OzJg2Mh1Dj9eoy7lhBTxjL16XzgGqFyO5ZLw zn+jexFFLQuMuVZw55QySm+XxEgIOJTmYOhnXnrGajV61x7Np7mABOtic82DykszmnX0 0u8A== X-Gm-Message-State: APjAAAX6cwPCJg6EdomcGwDOWjTeGqJC/Xv9MykD3MamuoN3MC1whJAx B1elw6u0CYlIBlvxj7TQKUitoA== X-Google-Smtp-Source: APXvYqyhhx8yoS7UXUXf4CfVaj6FrbAXNdjYL4HcvOy5AsnwYSpvcWyzddKtuWjjfNgAUoyiFzRfrg== X-Received: by 2002:ac8:34b7:: with SMTP id w52mr80878196qtb.11.1558626110443; Thu, 23 May 2019 08:41:50 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-49-251.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.49.251]) by smtp.gmail.com with ESMTPSA id x30sm17904824qtx.35.2019.05.23.08.41.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 May 2019 08:41:49 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hTpqn-00053x-Hl; Thu, 23 May 2019 12:41:49 -0300 Date: Thu, 23 May 2019 12:41:49 -0300 From: Jason Gunthorpe To: Jerome Glisse Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Leon Romanovsky , Doug Ledford , Artemy Kovalyov , Moni Shoua , Mike Marciniszyn , Kaike Wan , Dennis Dalessandro Subject: Re: [PATCH v4 0/1] Use HMM for ODP v4 Message-ID: <20190523154149.GB12159@ziepe.ca> References: <20190411181314.19465-1-jglisse@redhat.com> <20190506195657.GA30261@ziepe.ca> <20190521205321.GC3331@redhat.com> <20190522005225.GA30819@ziepe.ca> <20190522174852.GA23038@redhat.com> <20190522235737.GD15389@ziepe.ca> <20190523150432.GA5104@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523150432.GA5104@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 11:04:32AM -0400, Jerome Glisse wrote: > On Wed, May 22, 2019 at 08:57:37PM -0300, Jason Gunthorpe wrote: > > On Wed, May 22, 2019 at 01:48:52PM -0400, Jerome Glisse wrote: > > > > > > > So attached is a rebase on top of 5.2-rc1, i have tested with pingpong > > > > > (prefetch and not and different sizes). Seems to work ok. > > > > > > > > Urk, it already doesn't apply to the rdma tree :( > > > > > > > > The conflicts are a little more extensive than I'd prefer to handle.. > > > > Can I ask you to rebase it on top of this branch please: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=wip/jgg-for-next > > > > > > > > Specifically it conflicts with this patch: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=wip/jgg-for-next&id=d2183c6f1958e6b6dfdde279f4cee04280710e34 > > > > There is at least one more serious blocker here: > > > > config ARCH_HAS_HMM_MIRROR > > bool > > default y > > depends on (X86_64 || PPC64) > > depends on MMU && 64BIT > > > > I can't loose ARM64 support for ODP by merging this, that is too > > serious of a regression. > > > > Can you fix it? > > 5.2 already has patch to fix the Kconfig (ARCH_HAS_HMM_MIRROR and > ARCH_HAS_HMM_DEVICE replacing ARCH_HAS_HMM) I need to update nouveau Newer than 5.2-rc1? Is this why ARCH_HAS_HMM_MIRROR is not used anywhere? > in 5.3 so that i can drop the old ARCH_HAS_HMM and then convert > core mm in 5.4 to use ARCH_HAS_HMM_MIRROR and ARCH_HAS_HMM_DEVICE > instead of ARCH_HAS_HMM My problem is that ODP needs HMM_MIRROR which needs HMM & ARCH_HAS_HMM - and then even if fixed we still have the ARCH_HAS_HMM_MIRROR restricted to ARM64.. Can we broaden HMM_MIRROR to all arches? I would very much prefer that. > So it seems it will have to wait 5.4 for ODP. I will re-spin the > patch for ODP once i am done reviewing Ralph changes and yours > for 5.3. I think we are still OK for 5.3. If mm takes the fixup patches so hmm mirror is as reliable as ODP's existing stuff, and patch from you to enable ARM64, then we can continue to merge into 5.3 So, let us try to get acks on those other threads.. Jason