From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B62DC072B5 for ; Fri, 24 May 2019 19:04:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D886021848 for ; Fri, 24 May 2019 19:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558724687; bh=1Otej3DqW8kLZe+otOAU42a39fB+op/iRkL/qfZt6fg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mXL7G/hwrY8J7/0H03gl+S8ei9VJmd+n2/EX46oMIQh72BNOv7hzYG6xZRYQQX1jg dtKpDxptqQj8Dz+wLVrdA2onWh446bmLv6atsvUBqBn4QrWeran34Er36ODCMM8/We zxoA8tVmALPX6H+2mmEwb/jcuWYhsygQco9cd9Ac= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732011AbfEXTEr (ORCPT ); Fri, 24 May 2019 15:04:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:36190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbfEXTEq (ORCPT ); Fri, 24 May 2019 15:04:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4291B21848; Fri, 24 May 2019 19:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558724685; bh=1Otej3DqW8kLZe+otOAU42a39fB+op/iRkL/qfZt6fg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NwJLeqRFtTod+iPoBP/acd7TE4ryKxbyswv6Fpy55OK9uiD+XFkAvnx6y2TJtSsR5 WsD5YNJLSWx7SKouF3NC7IDgLog9/Gn8ermSMQbQ1dhTfRgWvRgKRYxd3EYIGYnS+9 yVWCGDay8rhC1zBPnQn4GelPufHKIaDoB4xmCChA= Date: Fri, 24 May 2019 21:04:43 +0200 From: Greg KH To: Muchun Song Cc: rafael@kernel.org, benh@kernel.crashing.org, prsood@codeaurora.org, mojha@codeaurora.org, gkohli@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, zhaowuyun@wingtech.com Subject: Re: [PATCH v4] driver core: Fix use-after-free and double free on glue directory Message-ID: <20190524190443.GB29565@kroah.com> References: <20190516142342.28019-1-smuchun@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190516142342.28019-1-smuchun@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 16, 2019 at 10:23:42PM +0800, Muchun Song wrote: > There is a race condition between removing glue directory and adding a new > device under the glue directory. It can be reproduced in following test: Is this related to: Subject: [PATCH v3] drivers: core: Remove glue dirs early only when refcount is 1 ? If so, why is the solution so different? thanks, greg k-h