From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08FD8C04AB6 for ; Tue, 28 May 2019 18:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5F0620883 for ; Tue, 28 May 2019 18:06:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbfE1SGA (ORCPT ); Tue, 28 May 2019 14:06:00 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49346 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726576AbfE1SF7 (ORCPT ); Tue, 28 May 2019 14:05:59 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3F92A12D6C857; Tue, 28 May 2019 11:05:59 -0700 (PDT) Date: Tue, 28 May 2019 11:05:58 -0700 (PDT) Message-Id: <20190528.110558.1330628926671013610.davem@davemloft.net> To: Jisheng.Zhang@synaptics.com Cc: thomas.petazzoni@bootlin.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: mvneta: Fix err code path of probe From: David Miller In-Reply-To: <20190527185513.04aca133@xhacker.debian> References: <20190527185513.04aca133@xhacker.debian> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 May 2019 11:05:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jisheng Zhang Date: Mon, 27 May 2019 11:04:17 +0000 > Fix below issues in err code path of probe: > 1. we don't need to unregister_netdev() because the netdev isn't > registered. > 2. when register_netdev() fails, we also need to destroy bm pool for > HWBM case. > > Fixes: dc35a10f68d3 ("net: mvneta: bm: add support for hardware buffer management") > Signed-off-by: Jisheng Zhang Applied and queued up for -stable.