From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A21C04AB6 for ; Tue, 28 May 2019 05:18:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAFC52075C for ; Tue, 28 May 2019 05:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbfE1FSN (ORCPT ); Tue, 28 May 2019 01:18:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33976 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726305AbfE1FSM (ORCPT ); Tue, 28 May 2019 01:18:12 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E244E300159E; Tue, 28 May 2019 05:18:11 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-84.pek2.redhat.com [10.72.12.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B2F8060C64; Tue, 28 May 2019 05:18:06 +0000 (UTC) Date: Tue, 28 May 2019 13:18:02 +0800 From: Dave Young To: Kairui Song Cc: Bhupesh Sharma , Linux Kernel Mailing List , Rahul Lakkireddy , "David S . Miller" , Eric Biederman , Alexey Dobriyan , Andrew Morton , "kexec@lists.infradead.org" Subject: Re: [PATCH v3] vmcore: Add a kernel parameter vmcore_device_dump Message-ID: <20190528051802.GA8195@dhcp-128-65.nay.redhat.com> References: <20190524062922.26399-1-kasong@redhat.com> <20190524125456.GA3342@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 28 May 2019 05:18:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/27/19 at 01:05pm, Kairui Song wrote: > On Mon, May 27, 2019 at 2:45 AM Bhupesh Sharma wrote: > > > > On Fri, May 24, 2019 at 6:25 PM Dave Young wrote: > > > > > > On 05/24/19 at 02:29pm, Kairui Song wrote: > > > > Since commit 2724273e8fd0 ("vmcore: add API to collect hardware dump in > > > > second kernel"), drivers is allowed to add device related dump data to > > > > vmcore as they want by using the device dump API. This have a potential > > > > issue, the data is stored in memory, drivers may append too much data > > > > and use too much memory. The vmcore is typically used in a kdump kernel > > > > which runs in a pre-reserved small chunk of memory. So as a result it > > > > will make kdump unusable at all due to OOM issues. > > > > > > > > So introduce new vmcore_device_dump= kernel parameter, and disable > > > > device dump by default. User can enable it only if device dump data is > > > > required for debugging, and have the chance to increase the kdump > > > > reserved memory accordingly before device dump fails kdump. > > > > > > > > Signed-off-by: Kairui Song > > > > > > > > --- > > > > > > > > Update from V2: > > > > - Improve related docs > > > > > > > > Update from V1: > > > > - Use bool parameter to turn it on/off instead of letting user give > > > > the size limit. Size of device dump is hard to determine. > > > > > > > > Documentation/admin-guide/kernel-parameters.txt | 14 ++++++++++++++ > > > > fs/proc/Kconfig | 6 ++++-- > > > > fs/proc/vmcore.c | 13 +++++++++++++ > > > > 3 files changed, 31 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > > > > index 138f6664b2e2..3706ad9e1d97 100644 > > > > --- a/Documentation/admin-guide/kernel-parameters.txt > > > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > > > @@ -5078,6 +5078,20 @@ > > > > decrease the size and leave more room for directly > > > > mapped kernel RAM. > > > > > > > > + vmcore_device_dump= [KNL,KDUMP] > > > > + Format: {"off" | "on"} > > > > + Depends on CONFIG_PROC_VMCORE_DEVICE_DUMP. > > > > + This parameter allows enable or disable device dump > > > > + for vmcore on kernel start-up. > > > > + Device dump allows drivers to append dump data to > > > > + vmcore so you can collect driver specified debug info. > > > > + Note that the drivers could append the data without > > > > + any limit, and the data is stored in memory, this may > > > > + bring a significant memory stress. If you want to turn > > > > + on this option, make sure you have reserved enough memory > > > > + with crashkernel= parameter. > > > > + default: off > > > > + > > > > vmcp_cma=nn[MG] [KNL,S390] > > > > Sets the memory size reserved for contiguous memory > > > > allocations for the vmcp device driver. > > > > diff --git a/fs/proc/Kconfig b/fs/proc/Kconfig > > > > index 817c02b13b1d..1a7a38976bb0 100644 > > > > --- a/fs/proc/Kconfig > > > > +++ b/fs/proc/Kconfig > > > > @@ -56,8 +56,10 @@ config PROC_VMCORE_DEVICE_DUMP > > > > recovery kernel's initramfs to collect its underlying device > > > > snapshot. > > > > > > > > - If you say Y here, the collected device dumps will be added > > > > - as ELF notes to /proc/vmcore. > > > > + If you say Y here, a new kernel parameter 'vmcore_device_dump' > > > > + will be available. You can then enable device dump by passing > > > > > > "a new kernel parameter 'vmcore_device_dump' will be available" is not > > > necessary, "new" is a not a clear word. I suggest to remove this > > > sentence. > > > > > > s/You can then/You can > > > > I agree with Dave. We are just trying to say here that even if > > CONFIG_PROC_VMCORE_DEVICE_DUMP is set to Y, one can still disable the > > device dump feature by passing parameter 'vmcore_device_dump=off' to > > the kernel. > > > > May be you can use the wording I mentioned in the v2 patch review, > > which tried to convey a similar meaning. > > > > With the change addressed: > > Reviewed-by: Bhupesh Sharma > > > > Thanks, > > Bhupesh > > > OK, How about: > > If you say Y here, device dump is still disabled by default. > You can enable device dump by passing 'vmcore_device_dump=on' > to kernel, the collected device dumps will be added as ELF > notes to /proc/vmcore. > > If you think this is good I'll send V4 including the changes. Kairui, looks good. rethink about it, to be even simple, just replace the __setup with core_param like crash_kexec_post_notifiers, no need on/off. > > -- > Best Regards, > Kairui Song Thanks Dave