From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B2CDC04AB6 for ; Tue, 28 May 2019 09:07:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2303208C3 for ; Tue, 28 May 2019 09:07:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727689AbfE1JHM (ORCPT ); Tue, 28 May 2019 05:07:12 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:17595 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727322AbfE1JHL (ORCPT ); Tue, 28 May 2019 05:07:11 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 86761B8F878AA4309DF5; Tue, 28 May 2019 17:07:08 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.439.0; Tue, 28 May 2019 17:07:01 +0800 From: YueHaibing To: , , , CC: , , YueHaibing Subject: [PATCH -next] lockd: Make two symbols static Date: Tue, 28 May 2019 17:06:52 +0800 Message-ID: <20190528090652.13288-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix sparse warnings: fs/lockd/clntproc.c:57:6: warning: symbol 'nlmclnt_put_lockowner' was not declared. Should it be static? fs/lockd/svclock.c:409:35: warning: symbol 'nlmsvc_lock_ops' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- fs/lockd/clntproc.c | 2 +- fs/lockd/svclock.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/lockd/clntproc.c b/fs/lockd/clntproc.c index 0ff8ad4..b11f2af 100644 --- a/fs/lockd/clntproc.c +++ b/fs/lockd/clntproc.c @@ -54,7 +54,7 @@ nlmclnt_get_lockowner(struct nlm_lockowner *lockowner) return lockowner; } -void nlmclnt_put_lockowner(struct nlm_lockowner *lockowner) +static void nlmclnt_put_lockowner(struct nlm_lockowner *lockowner) { if (!refcount_dec_and_lock(&lockowner->count, &lockowner->host->h_lock)) return; diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c index 5f9f19b..61d3cc2 100644 --- a/fs/lockd/svclock.c +++ b/fs/lockd/svclock.c @@ -406,7 +406,7 @@ static void nlmsvc_locks_release_private(struct file_lock *fl) nlmsvc_put_lockowner((struct nlm_lockowner *)fl->fl_owner); } -const struct file_lock_operations nlmsvc_lock_ops = { +static const struct file_lock_operations nlmsvc_lock_ops = { .fl_copy_lock = nlmsvc_locks_copy_lock, .fl_release_private = nlmsvc_locks_release_private, }; -- 2.7.4