From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AABE0C04AB6 for ; Tue, 28 May 2019 16:40:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E8262166E for ; Tue, 28 May 2019 16:40:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="XDQ9N9RT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727033AbfE1Qka (ORCPT ); Tue, 28 May 2019 12:40:30 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35992 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726362AbfE1Qka (ORCPT ); Tue, 28 May 2019 12:40:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5O70O6OB10YmWngTAKAkcQIdQ8sIfTqZZD+NK309vZU=; b=XDQ9N9RTp0puDZabOwzrob//Kv y5oy66ii5xp4F7st5YdpcGsQfHk49y6kt4E3Nzy9SeaASuX4lI0LHIfxYYfomjcKTlLGyWF2elUYj DESlvmLxyQMfXIHDIaQ9P/Wb7VkStdDsD43MTeQEvS5DmeCYX7npfkM0NZCBD5mlRUME=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hVf99-0000Gw-95; Tue, 28 May 2019 18:40:19 +0200 Date: Tue, 28 May 2019 18:40:19 +0200 From: Andrew Lunn To: biao huang Cc: David Miller , jianguo.zhang@mediatek.com, alexandre.torgue@st.com, boon.leong.ong@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yt.shen@mediatek.com, joabreu@synopsys.com, linux-mediatek@lists.infradead.org, mcoquelin.stm32@gmail.com, matthias.bgg@gmail.com, peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [v3, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4 Message-ID: <20190528164019.GR18059@lunn.ch> References: <1558926867-16472-1-git-send-email-biao.huang@mediatek.com> <1558926867-16472-2-git-send-email-biao.huang@mediatek.com> <20190527.100800.1719164073038257292.davem@davemloft.net> <1559008369.24897.66.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1559008369.24897.66.camel@mhfsdcap03> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 28, 2019 at 09:52:49AM +0800, biao huang wrote: > Dear David, > > On Mon, 2019-05-27 at 10:08 -0700, David Miller wrote: > > From: Biao Huang > > Date: Mon, 27 May 2019 11:14:27 +0800 > > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c > > > index 5e98da4..029a3db 100644 > > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c > > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c > > > @@ -403,41 +403,50 @@ static void dwmac4_set_filter(struct mac_device_info *hw, > > > struct net_device *dev) > > > { > > > void __iomem *ioaddr = (void __iomem *)dev->base_addr; > > > - unsigned int value = 0; > > > + unsigned int value; > > > + int numhashregs = (hw->multicast_filter_bins >> 5); > > > + int mcbitslog2 = hw->mcast_bits_log2; > > > + int i; > > > > Please retain the reverse christmas tree ordering here. > I'm a little confused about the reverse xmas tree ordering. > > should I reorder them only according to the total length like this: > > void __iomem *ioaddr = (void __iomem *)dev->base_addr; > int numhashregs = (hw->multicast_filter_bins >> 5); > int mcbitslog2 = hw->mcast_bits_log2; > unsigned int value; > int i; Yes. Andrew