From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A390C072B1 for ; Tue, 28 May 2019 17:13:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35E5F2075B for ; Tue, 28 May 2019 17:13:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eaq0BTRP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727353AbfE1RM7 (ORCPT ); Tue, 28 May 2019 13:12:59 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:40130 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbfE1RM7 (ORCPT ); Tue, 28 May 2019 13:12:59 -0400 Received: by mail-lf1-f68.google.com with SMTP id h13so15206400lfc.7; Tue, 28 May 2019 10:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7II5+XRnVobtVPgQVRQrDR8x4e5To08TyrztMHGvqag=; b=eaq0BTRPkhNafZhWSSYSrscltuZlK8p6kHWOeCVXycDQv7t3RspcGhqc4CbVFRfJ0/ o7HJXatIFeoKZxyCMT287FoSfvrUs0U0xqqF+ZyaTxsF6AXOvHhx+mEnvBMiZVkkC7ec QCS0S+APb1j6fW2ryNi4o7g80ajjVeRBHQNbzfaBo7pN07pH1YZkz60t0gSOOA3Sa77n IUDDmczlKJ9hmuAndnQn4+Y/SUZKWO+OMmA80g+gjOLOd+UpCkLuevIe+dS8TuJtPJey 2PC562PZ6yYaNgc3BidpuZdLxw+bNgr4tYYphKwEZ3XqIzT7w38tkPatdRI9FkWb/PTS N+nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7II5+XRnVobtVPgQVRQrDR8x4e5To08TyrztMHGvqag=; b=DUO5En1dTvbSXbQmc1GJnFFO6BTzt4kM8cklYJFWB48yixiorxlkVoiTq/CxBHIffZ iXHVIvJO+E1H3MlLjs+L7VjJ6bmW9oXtjSuz+E1M80xJUtSiXHOVRBxHWDMMs+vYxdr3 xgwBrmnqGu/zrcbdfPuBkBn0kMUBrw3XWHGcaUoTh0wehFtWK2F/YtcWJRKTGTcxWsX7 r0foGPhd8Knt/9VDehH3QdBJALvz7SfQKfZ30t0k8j6p7VEpTpGu/BO1vwA2kowJVvx+ 6IGIadI3kyMYpxG1EcOxZYvXPUNygFjtHuIpGsSebpqwxVYLDjGgIyjCGU7ptKvSbhza TB/Q== X-Gm-Message-State: APjAAAV93OVsPOgfGkrb1W0J7jh4irOp4k8Y9FXBiOP1B7gDtgZUVm2l ftnfML7vEQ2TwlaUI2Om6fk= X-Google-Smtp-Source: APXvYqweo1MPDUPsmU7agUat02Negiwx5X1FenEPDIVNxQGPC9Z7TsrTpK50AruQozndnwRD+b61rA== X-Received: by 2002:ac2:4908:: with SMTP id n8mr3692243lfi.10.1559063577452; Tue, 28 May 2019 10:12:57 -0700 (PDT) Received: from esperanza ([176.120.239.149]) by smtp.gmail.com with ESMTPSA id x14sm2989317lfe.83.2019.05.28.10.12.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 10:12:56 -0700 (PDT) Date: Tue, 28 May 2019 20:12:54 +0300 From: Vladimir Davydov To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Johannes Weiner , Michal Hocko , Rik van Riel , Shakeel Butt , Christoph Lameter , cgroups@vger.kernel.org, Waiman Long Subject: Re: [PATCH v5 4/7] mm: unify SLAB and SLUB page accounting Message-ID: <20190528171254.ymnytie2uc4hwd4v@esperanza> References: <20190521200735.2603003-1-guro@fb.com> <20190521200735.2603003-5-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521200735.2603003-5-guro@fb.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 01:07:32PM -0700, Roman Gushchin wrote: > Currently the page accounting code is duplicated in SLAB and SLUB > internals. Let's move it into new (un)charge_slab_page helpers > in the slab_common.c file. These helpers will be responsible > for statistics (global and memcg-aware) and memcg charging. > So they are replacing direct memcg_(un)charge_slab() calls. > > Signed-off-by: Roman Gushchin > Reviewed-by: Shakeel Butt > Acked-by: Christoph Lameter Makes sense even without the rest of the series, Acked-by: Vladimir Davydov