From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13027C04AB3 for ; Wed, 29 May 2019 07:00:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D703B208CB for ; Wed, 29 May 2019 07:00:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfE2HAQ (ORCPT ); Wed, 29 May 2019 03:00:16 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:58394 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725894AbfE2HAP (ORCPT ); Wed, 29 May 2019 03:00:15 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 44A9F1000478F; Wed, 29 May 2019 00:00:15 -0700 (PDT) Date: Wed, 29 May 2019 00:00:14 -0700 (PDT) Message-Id: <20190529.000014.920973579137715506.davem@davemloft.net> To: gustavo@embeddedor.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] macvlan: Replace strncpy() by strscpy() From: David Miller In-Reply-To: <20190527183855.GA32553@embeddedor> References: <20190527183855.GA32553@embeddedor> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 May 2019 00:00:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Mon, 27 May 2019 13:38:55 -0500 > The strncpy() function is being deprecated. Replace it by the safer > strscpy() and fix the following Coverity warning: > > "Calling strncpy with a maximum size argument of 16 bytes on destination > array ifrr.ifr_ifrn.ifrn_name of size 16 bytes might leave the destination > string unterminated." > > Notice that, unlike strncpy(), strscpy() always null-terminates the > destination string. > > Addresses-Coverity-ID: 1445537 ("Buffer not null terminated") > Signed-off-by: Gustavo A. R. Silva Applied.