From: Guo Ren <guoren@kernel.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 2/7] csky: entry: Remove unneeded need_resched() loop
Date: Wed, 29 May 2019 09:48:41 +0800 [thread overview]
Message-ID: <20190529014841.GA23749@guoren-Inspiron-7460> (raw)
In-Reply-To: <20190528104848.13160-3-valentin.schneider@arm.com>
Thx Valentin,
You are right, Approved.
Best Regards
Guo Ren
On Tue, May 28, 2019 at 11:48:43AM +0100, Valentin Schneider wrote:
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Guo Ren <guoren@kernel.org>
> ---
> arch/csky/kernel/entry.S | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/csky/kernel/entry.S b/arch/csky/kernel/entry.S
> index a7e84ccccbd8..679afbcc2001 100644
> --- a/arch/csky/kernel/entry.S
> +++ b/arch/csky/kernel/entry.S
> @@ -292,11 +292,7 @@ ENTRY(csky_irq)
> ldw r8, (r9, TINFO_FLAGS)
> btsti r8, TIF_NEED_RESCHED
> bf 2f
> -1:
> jbsr preempt_schedule_irq /* irq en/disable is done inside */
> - ldw r7, (r9, TINFO_FLAGS) /* get new tasks TI_FLAGS */
> - btsti r7, TIF_NEED_RESCHED
> - bt 1b /* go again */
> #endif
> 2:
> jmpi ret_from_exception
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-05-29 1:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 10:48 [PATCH RESEND 0/7] entry: preempt_schedule_irq() callers scrub Valentin Schneider
2019-05-28 10:48 ` [PATCH RESEND 1/7] sched/core: Fix preempt_schedule() interrupt return comment Valentin Schneider
2019-05-28 10:58 ` Valentin Schneider
2019-06-11 19:30 ` Thomas Gleixner
2019-05-28 10:48 ` [PATCH RESEND 2/7] csky: entry: Remove unneeded need_resched() loop Valentin Schneider
2019-05-29 1:48 ` Guo Ren [this message]
2019-05-28 10:48 ` [PATCH RESEND 3/7] h8300: " Valentin Schneider
2019-05-28 10:48 ` [PATCH RESEND 4/7] microblaze: " Valentin Schneider
2019-05-28 10:48 ` [PATCH RESEND 5/7] RISC-V: " Valentin Schneider
2019-05-30 4:09 ` Palmer Dabbelt
2019-05-30 16:37 ` Valentin Schneider
2019-05-28 10:48 ` [PATCH RESEND 6/7] sh: " Valentin Schneider
2019-05-28 10:48 ` [PATCH RESEND 7/7] sh64: " Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529014841.GA23749@guoren-Inspiron-7460 \
--to=guoren@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®