From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECA7C28CC0 for ; Wed, 29 May 2019 15:09:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C06523B88 for ; Wed, 29 May 2019 15:09:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726827AbfE2PJO (ORCPT ); Wed, 29 May 2019 11:09:14 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47684 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbfE2PJO (ORCPT ); Wed, 29 May 2019 11:09:14 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C65A341; Wed, 29 May 2019 08:09:13 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 342A03F5AF; Wed, 29 May 2019 08:09:12 -0700 (PDT) Date: Wed, 29 May 2019 16:09:09 +0100 From: Will Deacon To: Sami Tolvanen Cc: Catalin Marinas , Mark Rutland , Kees Cook , Nick Desaulniers , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] fix function type mismatches in syscall wrappers Message-ID: <20190529150909.GE11154@fuggles.cambridge.arm.com> References: <20190524221118.177548-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190524221118.177548-1-samitolvanen@google.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 03:11:15PM -0700, Sami Tolvanen wrote: > These patches fix type mismatches in arm64 syscall wrapper > definitions, which trip indirect call checks with Control-Flow > Integrity. > > Changes in v3: > - instead of SYSCALL_DEFINE0, just define __arm64_sys_ni_syscall > with the correct type to avoid unnecessary error injection Thanks, I've picked this up for -rc3. Will