From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E323C28CC0 for ; Wed, 29 May 2019 15:12:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 738CC23BB9 for ; Wed, 29 May 2019 15:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbfE2PMc (ORCPT ); Wed, 29 May 2019 11:12:32 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47880 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbfE2PMc (ORCPT ); Wed, 29 May 2019 11:12:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86AA8341; Wed, 29 May 2019 08:12:31 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FC923F5AF; Wed, 29 May 2019 08:12:30 -0700 (PDT) Date: Wed, 29 May 2019 16:12:27 +0100 From: Will Deacon To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linux Containers , Oleg Nesterov , linux-arch@vger.kernel.org, Dave Martin , James Morse Subject: Re: [REVIEW][PATCHv2 03/26] signal/arm64: Use force_sig not force_sig_fault for SIGKILL Message-ID: <20190529151227.GF11154@fuggles.cambridge.arm.com> References: <20190523003916.20726-1-ebiederm@xmission.com> <20190523003916.20726-4-ebiederm@xmission.com> <20190523101702.GG26646@fuggles.cambridge.arm.com> <875zq1gnh4.fsf_-_@xmission.com> <20190523161509.GE31896@fuggles.cambridge.arm.com> <8736l4evkn.fsf@xmission.com> <20190524100008.GE3432@fuggles.cambridge.arm.com> <87o93rcwee.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o93rcwee.fsf@xmission.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 05:36:41PM -0500, Eric W. Biederman wrote: > Will Deacon writes: > > > On Thu, May 23, 2019 at 03:59:20PM -0500, Eric W. Biederman wrote: > >> Will Deacon writes: > >> > >> > On Thu, May 23, 2019 at 11:11:19AM -0500, Eric W. Biederman wrote: > >> >> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > >> >> index ade32046f3fe..e45d5b440fb1 100644 > >> >> --- a/arch/arm64/kernel/traps.c > >> >> +++ b/arch/arm64/kernel/traps.c > >> >> @@ -256,7 +256,10 @@ void arm64_force_sig_fault(int signo, int code, void __user *addr, > >> >> const char *str) > >> >> { > >> >> arm64_show_signal(signo, str); > >> >> - force_sig_fault(signo, code, addr, current); > >> >> + if (signo == SIGKILL) > >> >> + force_sig(SIGKILL, current); > >> >> + else > >> >> + force_sig_fault(signo, code, addr, current); > >> >> } > >> > > >> > Acked-by: Will Deacon > >> > > >> > Are you planning to send this series on, or would you like me to pick this > >> > into the arm64 tree? > >> > >> I am planning on taking this through siginfo tree, unless it causes > >> problems. > > > > Okey doke, it would just be nice to see this patch land in 5.2, that's > > all. > > As this does not appear to have any real world consequences I am aiming > at 5.3. If someone else would like to take it and feed it to Linus > sooner I won't object. Thanks. I've picked this patch up as part of the arm64 fixes I plan to send for -rc3. Will