From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7188C28CC0 for ; Wed, 29 May 2019 21:23:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8660D241B7 for ; Wed, 29 May 2019 21:23:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbfE2VX4 (ORCPT ); Wed, 29 May 2019 17:23:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36758 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbfE2VX4 (ORCPT ); Wed, 29 May 2019 17:23:56 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E9C63082B40; Wed, 29 May 2019 21:23:56 +0000 (UTC) Received: from x1.home (ovpn-116-22.phx2.redhat.com [10.3.116.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 129FA60C4E; Wed, 29 May 2019 21:23:56 +0000 (UTC) Date: Wed, 29 May 2019 15:23:55 -0600 From: Alex Williamson To: "Thomas Meyer" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfio-pci/nvlink2: Use vma_pages function instead of explicit computation Message-ID: <20190529152355.5ea4823f@x1.home> In-Reply-To: <1559160524648-1049343203-1-diffsplit-thomas@m3y3r.de> References: <1559160524618-2047588593-0-diffsplit-thomas@m3y3r.de> <1559160524648-1049343203-1-diffsplit-thomas@m3y3r.de> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 29 May 2019 21:23:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 May 2019 22:11:06 +0200 "Thomas Meyer" wrote: > Use vma_pages function on vma object instead of explicit computation. > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c > --- a/drivers/vfio/pci/vfio_pci_nvlink2.c > +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c > @@ -161,7 +161,7 @@ static int vfio_pci_nvgpu_mmap(struct vf > > atomic_inc(&data->mm->mm_count); > ret = (int) mm_iommu_newdev(data->mm, data->useraddr, > - (vma->vm_end - vma->vm_start) >> PAGE_SHIFT, > + vma_pages(vma), > data->gpu_hpa, &data->mem); > > trace_vfio_pci_nvgpu_mmap(vdev->pdev, data->gpu_hpa, data->useraddr, Not sure if our emails crossed in flight[1], but the other patch[2] still has precedence. You're welcome to add a reviewed-by. Thanks, Alex [1]https://lkml.org/lkml/2019/5/29/871 [2]https://lkml.org/lkml/2019/5/16/658