From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C181CC072B1 for ; Thu, 30 May 2019 04:27:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A9D8254D3 for ; Thu, 30 May 2019 04:27:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559190423; bh=Zjnm/CSMq+WhVMJ0o+aNEUs/uCH6cf9Umkgw6pLqbpk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vDJ4JK8r5jW9vUkjFlciiW4XYxKDykd+zbWLak/4z6Wv83qWk2sdwMl2ZsndldgXB ASigR4Lu3zvnWtR2gZ1RhAJpUua0J2ePcOugniva1iMVLBIxgDx3RmtZ0+GGG4eirM Km+hPrkUab4zV4o6VNGAKzq2a/192dSTx2c4TlBM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733014AbfE3E1D (ORCPT ); Thu, 30 May 2019 00:27:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:33692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729854AbfE3DOZ (ORCPT ); Wed, 29 May 2019 23:14:25 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB5AE2455A; Thu, 30 May 2019 03:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186065; bh=Zjnm/CSMq+WhVMJ0o+aNEUs/uCH6cf9Umkgw6pLqbpk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vQmvO0H2pVhidVKoTWcOmkZGTxnxuEHnSdHqS2H+RYQda2Q17BHF0B9JSch8FG4bg ZCBgdAl8rkziKV9NJsABRsDhuqQe3iWUN/LYyGepUKB81M8w+XSy2syzCvf1jHVu+x 8xa4U68yOaKq28qrD/Fhzn4lEwKK909N9qnviTcI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Potnuri Bharat Teja , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.0 175/346] RDMA/cxgb4: Fix null pointer dereference on alloc_skb failure Date: Wed, 29 May 2019 20:04:08 -0700 Message-Id: <20190530030550.017430210@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030540.363386121@linuxfoundation.org> References: <20190530030540.363386121@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit a6d2a5a92e67d151c98886babdc86d530d27111c ] Currently if alloc_skb fails to allocate the skb a null skb is passed to t4_set_arp_err_handler and this ends up dereferencing the null skb. Avoid the NULL pointer dereference by checking for a NULL skb and returning early. Addresses-Coverity: ("Dereference null return") Fixes: b38a0ad8ec11 ("RDMA/cxgb4: Set arp error handler for PASS_ACCEPT_RPL messages") Signed-off-by: Colin Ian King Acked-by: Potnuri Bharat Teja Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/cxgb4/cm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 25a81fbb0d4d5..f1819b5272560 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -457,6 +457,8 @@ static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) skb_reset_transport_header(skb); } else { skb = alloc_skb(len, gfp); + if (!skb) + return NULL; } t4_set_arp_err_handler(skb, NULL, NULL); return skb; -- 2.20.1